javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 19:21:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): overlays now correctly unmount any child components after dismissing (#23149)

Browse Source 
resolves #23140
This commit is contained in:
Liam DeBeasi
2021-04-06 09:53:26 -04:00
committed by GitHub
parent 6df1215ee2
commit dee6eb30df
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/react/src/components/createOverlayComponent.tsx
View File

@ -94,6 +94,13 @@ export const createOverlayComponent = <
if (this.overlay && prevProps.isOpen !== this.props.isOpen && this.props.isOpen === false) { if (this.overlay && prevProps.isOpen !== this.props.isOpen && this.props.isOpen === false) {
await this.overlay.dismiss(); await this.overlay.dismiss();
isDismissing = false; isDismissing = false;
/**
* Now that the overlay is dismissed
* we need to render again so that any
* inner components will be unmounted
*/
this.forceUpdate();
} }
} }