From dee6eb30df370047bbc872b00ab6d801dd11fa81 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 6 Apr 2021 09:53:26 -0400 Subject: [PATCH] fix(react): overlays now correctly unmount any child components after dismissing (#23149) resolves #23140 --- packages/react/src/components/createOverlayComponent.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/react/src/components/createOverlayComponent.tsx b/packages/react/src/components/createOverlayComponent.tsx index 7cd3c83498..6dc1d69e3a 100644 --- a/packages/react/src/components/createOverlayComponent.tsx +++ b/packages/react/src/components/createOverlayComponent.tsx @@ -94,6 +94,13 @@ export const createOverlayComponent = < if (this.overlay && prevProps.isOpen !== this.props.isOpen && this.props.isOpen === false) { await this.overlay.dismiss(); isDismissing = false; + + /** + * Now that the overlay is dismissed + * we need to render again so that any + * inner components will be unmounted + */ + this.forceUpdate(); } }