javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(modal, popover): opening modal and popover now works even if overlay was added to ion-app directly (#24174)

Browse Source 
resolves #23728
This commit is contained in:
Liam DeBeasi
2021-11-08 10:19:23 -05:00
committed by GitHub
parent b3759aed5b
commit da339a8a74
11 changed files with 157 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/src/css/core.scss
View File

@ -86,6 +86,30 @@ html.ios ion-modal .ion-page {
}
}
/**
* Subsequent modals should not have a backdrop/box shadow
* as it will cause the screen to appear to get progressively
* darker. With Ionic 6, declarative modals made it
* possible to have multiple non-presented modals in the DOM,
* so we could no longer rely on ion-modal:first-of-type.
* Here we disable the opacity/box-shadow for every modal
* that comes after the first presented modal.
*
* Note: ion-modal:not(.overlay-hidden):first-of-type
* does not match the first modal to not have
* the .overlay-hidden class, it will match the
* first modal in general only if it does not
* have the .overlay-hidden class.
* The :nth-child() pseudo-class has support
* for selectors which would help us here. At the
* time of writing it does not have great cross browser
* support.
*/
ion-modal:not(.overlay-hidden) ~ ion-modal {
--backdrop-opacity: 0;
--box-shadow: none;
}
// Ionic Colors
// --------------------------------------------------
// Generates the color classes and variables based on the