javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 21:48:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(select): remove relative positioning and get options in correct order

Browse Source
This commit is contained in:
Brandy Carney
2018-02-28 15:57:28 -05:00
parent ec994dd56b
commit d78aa36320
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/core/src/components/select/select.scss
View File

@ -4,8 +4,6 @@
// -------------------------------------------------- // --------------------------------------------------
ion-select { ion-select {
position: relative;
display: flex; display: flex;
overflow: hidden; overflow: hidden;
@ -41,6 +39,7 @@ ion-select {
white-space: nowrap; white-space: nowrap;
} }
// TODO item needs this class
.item-multiple-inputs ion-select { .item-multiple-inputs ion-select {
position: relative; position: relative;
} }

2
packages/core/src/components/select/select.tsx
View File

@ -189,7 +189,7 @@ export class Select {
@Listen('ionSelectOptionDidLoad') @Listen('ionSelectOptionDidLoad')
optLoad(ev: HTMLIonSelectOptionElementEvent) { optLoad(ev: HTMLIonSelectOptionElementEvent) {
const selectOption = ev.target; const selectOption = ev.target;
this.childOpts.push(selectOption); this.childOpts = Array.from(this.el.querySelectorAll('ion-select-option'));
if (this.value !== undefined && (Array.isArray(this.value) && this.value.indexOf(selectOption.value) > -1) || (selectOption.value === this.value)) { if (this.value !== undefined && (Array.isArray(this.value) && this.value.indexOf(selectOption.value) > -1) || (selectOption.value === this.value)) {
// this select has a value and this // this select has a value and this