From d78aa36320116e108da5e8cd7e334cc2d0db1c27 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Wed, 28 Feb 2018 15:57:28 -0500 Subject: [PATCH] fix(select): remove relative positioning and get options in correct order --- packages/core/src/components/select/select.scss | 3 +-- packages/core/src/components/select/select.tsx | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/core/src/components/select/select.scss b/packages/core/src/components/select/select.scss index 4b306f371b..852b853a3c 100644 --- a/packages/core/src/components/select/select.scss +++ b/packages/core/src/components/select/select.scss @@ -4,8 +4,6 @@ // -------------------------------------------------- ion-select { - position: relative; - display: flex; overflow: hidden; @@ -41,6 +39,7 @@ ion-select { white-space: nowrap; } +// TODO item needs this class .item-multiple-inputs ion-select { position: relative; } diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx index 93f8885700..db21ee6008 100644 --- a/packages/core/src/components/select/select.tsx +++ b/packages/core/src/components/select/select.tsx @@ -189,7 +189,7 @@ export class Select { @Listen('ionSelectOptionDidLoad') optLoad(ev: HTMLIonSelectOptionElementEvent) { const selectOption = ev.target; - this.childOpts.push(selectOption); + this.childOpts = Array.from(this.el.querySelectorAll('ion-select-option')); if (this.value !== undefined && (Array.isArray(this.value) && this.value.indexOf(selectOption.value) > -1) || (selectOption.value === this.value)) { // this select has a value and this