javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix(select): prevent click event from firing twice" (#27609)

Browse Source 
Reverts ionic-team/ionic-framework#27570

-------

The team is reconsidering this approach as it causes us to fight against
the browser. Discussions are ongoing internally, so I am going to revert
this patch until we can reach consensus.
This commit is contained in:
Liam DeBeasi
2023-06-06 17:18:19 -04:00
committed by GitHub
parent 5123981269
commit d4e1388fcb
2 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/components/select/select.scss
View File

@ -224,8 +224,6 @@ button {
cursor: inherit;
box-sizing: border-box;
pointer-events: none;
}
.select-wrapper .select-placeholder {

18
core/src/components/select/test/basic/index.html
View File

@ -124,19 +124,6 @@
<ion-select-option value="onions">Onions</ion-select-option>
</ion-select>
</ion-item>
<ion-item>
<ion-select
id="eventPropagation"
label="Stop Immediate Event Propagation"
placeholder="Select one"
interface="alert"
>
<ion-select-option value="apples">Apples</ion-select-option>
<ion-select-option value="oranges">Oranges</ion-select-option>
<ion-select-option value="pears">Pears</ion-select-option>
</ion-select>
</ion-item>
</ion-list>
</ion-content>
@ -165,11 +152,6 @@
message: '$1.50 charge for every topping',
};
customActionSheetSelect.interfaceOptions = customActionSheetOptions;
document.getElementById('eventPropagation').addEventListener('click', (evt) => {
evt.stopImmediatePropagation();
console.log('clicked');
});
</script>
</ion-app>
</body>