From d4e1388fcb0fae9d29e78e3016a6c3bf0ad39ff8 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 6 Jun 2023 17:18:19 -0400 Subject: [PATCH] Revert "fix(select): prevent click event from firing twice" (#27609) Reverts ionic-team/ionic-framework#27570 ------- The team is reconsidering this approach as it causes us to fight against the browser. Discussions are ongoing internally, so I am going to revert this patch until we can reach consensus. --- core/src/components/select/select.scss | 2 -- .../components/select/test/basic/index.html | 18 ------------------ 2 files changed, 20 deletions(-) diff --git a/core/src/components/select/select.scss b/core/src/components/select/select.scss index a79524b949..ca43b77a83 100644 --- a/core/src/components/select/select.scss +++ b/core/src/components/select/select.scss @@ -224,8 +224,6 @@ button { cursor: inherit; box-sizing: border-box; - - pointer-events: none; } .select-wrapper .select-placeholder { diff --git a/core/src/components/select/test/basic/index.html b/core/src/components/select/test/basic/index.html index ccf103c954..421dd4505f 100644 --- a/core/src/components/select/test/basic/index.html +++ b/core/src/components/select/test/basic/index.html @@ -124,19 +124,6 @@ Onions - - - - Apples - Oranges - Pears - - @@ -165,11 +152,6 @@ message: '$1.50 charge for every topping', }; customActionSheetSelect.interfaceOptions = customActionSheetOptions; - - document.getElementById('eventPropagation').addEventListener('click', (evt) => { - evt.stopImmediatePropagation(); - console.log('clicked'); - });