javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 19:21:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(ci): enable fail-fast for matrix jobs (#26713)

Browse Source 
Screenshot matrix jobs had "fail-fast: false". This enabled each test runner to provide its `playwright-report` directory so team members can view test failures. At the time, all tests ran even if previous tests failed.

In https://github.com/ionic-team/ionic-framework/pull/26447, we updated the Playwright config to have tests fail fast within a single test runner. However, other test runners continue to run. This is not helpful in the case of failing tests because the artifacts for each test runner will not be reported until all test runners are done.

This PR changes the matrix strategy to enable fail-fast (which is the default) so in-progress/queued test runners fail if a previous test runner fails.
This commit is contained in:
Liam DeBeasi
2023-02-03 13:46:01 -05:00
committed by GitHub
parent 7553cc7b0d
commit d084557bbc
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/build.yml vendored
View File

@ -44,10 +44,6 @@ jobs:
test-core-screenshot: test-core-screenshot:
strategy: strategy:
# This ensures that all screenshot shard
# failures are reported so the dev can
# review everything at once.
fail-fast: false
matrix: matrix:
# Divide the tests into n buckets # Divide the tests into n buckets
# and run those buckets in parallel. # and run those buckets in parallel.