From d084557bbc93c889f8b14c12e053797ddc159f6f Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 3 Feb 2023 13:46:01 -0500 Subject: [PATCH] chore(ci): enable fail-fast for matrix jobs (#26713) Screenshot matrix jobs had "fail-fast: false". This enabled each test runner to provide its `playwright-report` directory so team members can view test failures. At the time, all tests ran even if previous tests failed. In https://github.com/ionic-team/ionic-framework/pull/26447, we updated the Playwright config to have tests fail fast within a single test runner. However, other test runners continue to run. This is not helpful in the case of failing tests because the artifacts for each test runner will not be reported until all test runners are done. This PR changes the matrix strategy to enable fail-fast (which is the default) so in-progress/queued test runners fail if a previous test runner fails. --- .github/workflows/build.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 59c5eb2b1e..de52d23945 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -44,10 +44,6 @@ jobs: test-core-screenshot: strategy: - # This ensures that all screenshot shard - # failures are reported so the dev can - # review everything at once. - fail-fast: false matrix: # Divide the tests into n buckets # and run those buckets in parallel.