javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 01:03:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(select): fix api generation (#27217)

Browse Source 
<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->


<!-- Issues are required for both bug fixes and features. -->
Several CSS custom properties on `ion-select` are missing a `:` which is
breaking formatting on the docs:
https://ionicframework.com/docs/api/select#css-custom-properties


![image](https://user-images.githubusercontent.com/2721089/232563385-8919378a-c0a8-425b-8cd5-9572e6c0178f.png)


## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Adds `:` to remaining CSS props

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
This commit is contained in:
Liam DeBeasi
2023-04-17 13:45:38 -04:00
committed by GitHub
parent dca31f5940
commit c3c8c8e5ab
2 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/api.txt
View File

@ -1252,13 +1252,13 @@ ion-select,event,ionChange,SelectChangeEventDetail<any>,true
ion-select,event,ionDismiss,void,true
ion-select,event,ionFocus,void,true
ion-select,css-prop,--background
ion-select,css-prop,--border-color Color of the select border
ion-select,css-prop,--border-radius Radius of the select border
ion-select,css-prop,--border-style Style of the select border
ion-select,css-prop,--border-width Width of the select border
ion-select,css-prop,--highlight-color-focused The color of the highlight on the select when focused
ion-select,css-prop,--highlight-color-invalid The color of the highlight on the select when invalid
ion-select,css-prop,--highlight-color-valid The color of the highlight on the select when valid
ion-select,css-prop,--border-color
ion-select,css-prop,--border-radius
ion-select,css-prop,--border-style
ion-select,css-prop,--border-width
ion-select,css-prop,--highlight-color-focused
ion-select,css-prop,--highlight-color-invalid
ion-select,css-prop,--highlight-color-valid
ion-select,css-prop,--padding-bottom
ion-select,css-prop,--padding-end
ion-select,css-prop,--padding-start

14
core/src/components/select/select.scss
View File

@ -14,14 +14,14 @@
* @prop --placeholder-color: Color of the select placeholder text
* @prop --placeholder-opacity: Opacity of the select placeholder text
*
* @prop --highlight-color-focused The color of the highlight on the select when focused
* @prop --highlight-color-invalid The color of the highlight on the select when invalid
* @prop --highlight-color-valid The color of the highlight on the select when valid
* @prop --highlight-color-focused: The color of the highlight on the select when focused
* @prop --highlight-color-invalid: The color of the highlight on the select when invalid
* @prop --highlight-color-valid: The color of the highlight on the select when valid
*
* @prop --border-color Color of the select border
* @prop --border-radius Radius of the select border
* @prop --border-style Style of the select border
* @prop --border-width Width of the select border
* @prop --border-color: Color of the select border
* @prop --border-radius: Radius of the select border
* @prop --border-style: Style of the select border
* @prop --border-width: Width of the select border
*
* @prop --ripple-color: The color of the ripple effect on MD mode.
*/