test(chip): migrate to generators (#27301)

Issue number: N/A

---------

<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Chip tests are using legacy syntax

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Chip tests are using generator syntax

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
This commit is contained in:
Liam DeBeasi
2023-04-27 11:22:59 -04:00
committed by GitHub
parent 20d9d97dcf
commit b44ad49a4a
31 changed files with 56 additions and 48 deletions

View File

@ -1,36 +0,0 @@
import { expect } from '@playwright/test';
import { test } from '@utils/test/playwright';
test.describe('chip: rendering', () => {
test('should not have visual regressions', async ({ page }) => {
await page.goto('/src/components/chip/test/basic');
await page.setIonViewport();
await expect(page).toHaveScreenshot(`chip-basic-${page.getSnapshotSettings()}.png`);
});
test('should not clip descenders in item', async ({ page, skip }) => {
skip.rtl();
skip.mode('md');
test.info().annotations.push({
type: 'issue',
description: 'https://github.com/ionic-team/ionic-framework/issues/18313',
});
await page.setContent(`
<ion-list>
<ion-item>
<ion-chip>
<ion-label>Agreements</ion-label>
</ion-chip>
</ion-item>
</ion-list>
`);
const chip = page.locator('ion-chip');
await expect(chip).toHaveScreenshot(`chip-descender-${page.getSnapshotSettings()}.png`);
});
});

View File

@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import { configs, test } from '@utils/test/playwright';
configs().forEach(({ title, screenshot, config }) => {
test.describe(title('chip: rendering'), () => {
test('should not have visual regressions', async ({ page }) => {
await page.goto('/src/components/chip/test/basic', config);
await page.setIonViewport();
await expect(page).toHaveScreenshot(screenshot(`chip-basic`));
});
});
});
configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
test.describe(title('chip: descenders'), () => {
test('should not clip descenders in item', async ({ page }) => {
test.info().annotations.push({
type: 'issue',
description: 'https://github.com/ionic-team/ionic-framework/issues/18313',
});
await page.setContent(
`
<ion-list>
<ion-item>
<ion-chip>
<ion-label>Agreements</ion-label>
</ion-chip>
</ion-item>
</ion-list>
`,
config
);
const chip = page.locator('ion-chip');
await expect(chip).toHaveScreenshot(screenshot(`chip-descender`));
});
});
});

View File

@ -1,12 +0,0 @@
import { expect } from '@playwright/test';
import { test } from '@utils/test/playwright';
test.describe('chip: states', () => {
test('should not have visual regressions', async ({ page }) => {
await page.goto('/src/components/chip/test/states');
await page.setIonViewport();
await expect(page).toHaveScreenshot(`chip-states-${page.getSnapshotSettings()}.png`);
});
});

View File

@ -0,0 +1,14 @@
import { expect } from '@playwright/test';
import { configs, test } from '@utils/test/playwright';
configs().forEach(({ title, screenshot, config }) => {
test.describe(title('chip: states'), () => {
test('should not have visual regressions', async ({ page }) => {
await page.goto('/src/components/chip/test/states', config);
await page.setIonViewport();
await expect(page).toHaveScreenshot(screenshot(`chip-states`));
});
});
});