fix(checkbox, toggle): uniform helper text style for ionic theme (#30893)
Issue number: resolves # --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? Helper and Error text style it's not uniform between elements. ## What is the new behavior? * Changed the typography for `.checkbox-bottom` and `.toggle-bottom` to use `globals.$ion-body-sm-medium` for a more consistent appearance with other components. [[1]](diffhunk://#diff-796ffc72b6171910c25d5aad085bc245095c38f104d55e253e06282702205066L116-R116) [[2]](diffhunk://#diff-ad6128c5d08f42a970eab3a8c7081eaad590bd4ebbcd19ec4e6110a6f7977040L59-R70) * Updated the color of `.input-bottom .helper-text` and `.input-bottom .counter` to use `globals.$ion-text-subtlest` instead of `globals.$ion-primitives-neutral-800`, and `.input-bottom .error-text` to use `globals.$ion-text-danger`. * Standardized `.textarea-bottom .error-text` to use `globals.$ion-text-danger` and reordered the CSS for clarity, while `.textarea-bottom .helper-text` and `.textarea-bottom .counter` use `globals.$ion-text-subtlest`. * Updated `.toggle-bottom .error-text` to use `globals.$ion-text-danger` and `.toggle-bottom .helper-text` to use `globals.$ion-text-subtlest` for improved semantic clarity and consistency. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
@@ -113,7 +113,7 @@ input {
|
||||
// ----------------------------------------------------------------
|
||||
|
||||
.checkbox-bottom {
|
||||
@include globals.typography(globals.$ion-body-md-regular);
|
||||
@include globals.typography(globals.$ion-body-sm-medium);
|
||||
}
|
||||
|
||||
.checkbox-bottom .error-text {
|
||||
|
||||
|
Before Width: | Height: | Size: 1.7 KiB After Width: | Height: | Size: 1.5 KiB |
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 1.9 KiB |
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 2.0 KiB |
|
Before Width: | Height: | Size: 1.3 KiB After Width: | Height: | Size: 1.2 KiB |
|
Before Width: | Height: | Size: 1.6 KiB After Width: | Height: | Size: 1.5 KiB |
|
Before Width: | Height: | Size: 1.6 KiB After Width: | Height: | Size: 1.6 KiB |
|
Before Width: | Height: | Size: 1.5 KiB After Width: | Height: | Size: 1.4 KiB |
|
Before Width: | Height: | Size: 1.9 KiB After Width: | Height: | Size: 1.9 KiB |
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 2.1 KiB |
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 1.9 KiB |
|
Before Width: | Height: | Size: 5.2 KiB After Width: | Height: | Size: 4.3 KiB |
|
Before Width: | Height: | Size: 4.7 KiB After Width: | Height: | Size: 4.0 KiB |
|
Before Width: | Height: | Size: 1.5 KiB After Width: | Height: | Size: 1.4 KiB |
|
Before Width: | Height: | Size: 1.9 KiB After Width: | Height: | Size: 1.8 KiB |
|
Before Width: | Height: | Size: 2.2 KiB After Width: | Height: | Size: 2.1 KiB |
|
Before Width: | Height: | Size: 1.3 KiB After Width: | Height: | Size: 1.1 KiB |
|
Before Width: | Height: | Size: 1.5 KiB After Width: | Height: | Size: 1.5 KiB |
|
Before Width: | Height: | Size: 1.6 KiB After Width: | Height: | Size: 1.7 KiB |
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 1.9 KiB |
|
Before Width: | Height: | Size: 4.6 KiB After Width: | Height: | Size: 3.8 KiB |
|
Before Width: | Height: | Size: 4.8 KiB After Width: | Height: | Size: 2.9 KiB |
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 1.9 KiB |
|
Before Width: | Height: | Size: 5.2 KiB After Width: | Height: | Size: 4.3 KiB |
|
Before Width: | Height: | Size: 4.6 KiB After Width: | Height: | Size: 4.0 KiB |
@@ -266,15 +266,15 @@
|
||||
@include globals.typography(globals.$ion-body-sm-medium);
|
||||
}
|
||||
|
||||
.input-bottom .helper-text,
|
||||
.input-bottom .counter {
|
||||
color: globals.$ion-primitives-neutral-800;
|
||||
}
|
||||
|
||||
.input-bottom .error-text {
|
||||
color: globals.$ion-text-danger;
|
||||
}
|
||||
|
||||
.input-bottom .helper-text,
|
||||
.input-bottom .counter {
|
||||
color: globals.$ion-text-subtlest;
|
||||
}
|
||||
|
||||
:host(.has-focus.ion-valid) .helper-text {
|
||||
color: var(--highlight-color-valid);
|
||||
}
|
||||
|
||||
@@ -141,15 +141,15 @@ ion-icon {
|
||||
@include globals.typography(globals.$ion-body-sm-medium);
|
||||
}
|
||||
|
||||
.textarea-bottom .error-text {
|
||||
color: globals.$ion-text-danger;
|
||||
}
|
||||
|
||||
.textarea-bottom .helper-text,
|
||||
.textarea-bottom .counter {
|
||||
color: globals.$ion-text-subtlest;
|
||||
}
|
||||
|
||||
.textarea-bottom .error-text {
|
||||
color: globals.$ion-text-danger;
|
||||
}
|
||||
|
||||
:host(.has-focus.ion-valid) .helper-text {
|
||||
color: var(--highlight-color-valid);
|
||||
}
|
||||
|
||||
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 2.0 KiB |
|
Before Width: | Height: | Size: 2.4 KiB After Width: | Height: | Size: 2.3 KiB |
|
Before Width: | Height: | Size: 2.6 KiB After Width: | Height: | Size: 2.5 KiB |
|
Before Width: | Height: | Size: 2.1 KiB After Width: | Height: | Size: 2.0 KiB |
|
Before Width: | Height: | Size: 2.4 KiB After Width: | Height: | Size: 2.3 KiB |
|
Before Width: | Height: | Size: 2.6 KiB After Width: | Height: | Size: 2.5 KiB |
|
Before Width: | Height: | Size: 2.0 KiB After Width: | Height: | Size: 1.8 KiB |
|
Before Width: | Height: | Size: 2.2 KiB After Width: | Height: | Size: 2.1 KiB |
|
Before Width: | Height: | Size: 2.6 KiB After Width: | Height: | Size: 2.6 KiB |
|
Before Width: | Height: | Size: 2.9 KiB After Width: | Height: | Size: 2.3 KiB |
|
Before Width: | Height: | Size: 5.7 KiB After Width: | Height: | Size: 4.2 KiB |
|
Before Width: | Height: | Size: 5.3 KiB After Width: | Height: | Size: 3.9 KiB |
|
Before Width: | Height: | Size: 2.0 KiB After Width: | Height: | Size: 1.8 KiB |
|
Before Width: | Height: | Size: 2.2 KiB After Width: | Height: | Size: 2.1 KiB |
|
Before Width: | Height: | Size: 2.7 KiB After Width: | Height: | Size: 2.6 KiB |
|
Before Width: | Height: | Size: 2.0 KiB After Width: | Height: | Size: 1.8 KiB |
|
Before Width: | Height: | Size: 2.2 KiB After Width: | Height: | Size: 2.1 KiB |
|
Before Width: | Height: | Size: 2.7 KiB After Width: | Height: | Size: 2.6 KiB |
|
Before Width: | Height: | Size: 3.0 KiB After Width: | Height: | Size: 2.3 KiB |
|
Before Width: | Height: | Size: 5.7 KiB After Width: | Height: | Size: 4.2 KiB |
|
Before Width: | Height: | Size: 5.3 KiB After Width: | Height: | Size: 4.0 KiB |
|
Before Width: | Height: | Size: 3.0 KiB After Width: | Height: | Size: 2.3 KiB |
|
Before Width: | Height: | Size: 5.7 KiB After Width: | Height: | Size: 4.2 KiB |
|
Before Width: | Height: | Size: 5.3 KiB After Width: | Height: | Size: 4.0 KiB |
@@ -56,18 +56,18 @@
|
||||
// ----------------------------------------------------------------
|
||||
|
||||
.toggle-bottom {
|
||||
@include globals.typography(globals.$ion-body-md-regular);
|
||||
@include globals.typography(globals.$ion-body-sm-medium);
|
||||
}
|
||||
|
||||
// Toggle Hint Text
|
||||
// ----------------------------------------------------------------
|
||||
|
||||
.toggle-bottom .error-text {
|
||||
color: globals.$ion-semantics-danger-900;
|
||||
color: globals.$ion-text-danger;
|
||||
}
|
||||
|
||||
.toggle-bottom .helper-text {
|
||||
color: globals.$ion-primitives-neutral-900;
|
||||
color: globals.$ion-text-subtlest;
|
||||
}
|
||||
|
||||
// Toggle Native Wrapper: Focused
|
||||
|
||||