javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 19:21:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(overlays): bundling of overlays

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-03-06 23:16:58 +01:00
parent 174d9b5a41
commit 9650bec06a
8 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/components/action-sheet-controller/action-sheet-controller.tsx
View File

@ -33,7 +33,7 @@ export class ActionSheetController implements OverlayController {
*/
@Method()
create(opts?: ActionSheetOptions): Promise<HTMLIonActionSheetElement> {
return createOverlay('ion-action-sheet', opts);
return createOverlay(document.createElement('ion-action-sheet'), opts);
}
/*

2
packages/core/src/components/alert-controller/alert-controller.tsx
View File

@ -30,7 +30,7 @@ export class AlertController implements OverlayController {
*/
@Method()
create(opts?: AlertOptions): Promise<HTMLIonAlertElement> {
return createOverlay('ion-alert', opts);
return createOverlay(document.createElement('ion-alert'), opts);
}
/*

2
packages/core/src/components/loading-controller/loading-controller.tsx
View File

@ -30,7 +30,7 @@ export class LoadingController implements OverlayController {
*/
@Method()
create(opts?: LoadingOptions): Promise<HTMLIonLoadingElement> {
return createOverlay('ion-loading', opts);
return createOverlay(document.createElement('ion-loading'), opts);
}
/*

2
packages/core/src/components/modal-controller/modal-controller.tsx
View File

@ -30,7 +30,7 @@ export class ModalController implements OverlayController {
*/
@Method()
create(opts?: ModalOptions): Promise<HTMLIonModalElement> {
return createOverlay('ion-modal', opts);
return createOverlay(document.createElement('ion-modal'), opts);
}
/*

2
packages/core/src/components/picker-controller/picker-controller.tsx
View File

@ -30,7 +30,7 @@ export class PickerController implements OverlayController {
*/
@Method()
create(opts?: PickerOptions): Promise<HTMLIonPickerElement> {
return createOverlay('ion-picker', opts);
return createOverlay(document.createElement('ion-picker'), opts);
}
/*

2
packages/core/src/components/popover-controller/popover-controller.tsx
View File

@ -29,7 +29,7 @@ export class PopoverController implements OverlayController {
*/
@Method()
create(opts?: PopoverOptions): Promise<HTMLIonPopoverElement> {
return createOverlay('ion-popover', opts);
return createOverlay(document.createElement('ion-popover'), opts);
}
/*

2
packages/core/src/components/toast-controller/toast-controller.tsx
View File

@ -30,7 +30,7 @@ export class ToastController implements OverlayController {
*/
@Method()
create(opts?: ToastOptions): Promise<HTMLIonToastElement> {
return createOverlay('ion-toast', opts);
return createOverlay(document.createElement('ion-toast'), opts);
}
/*

6
packages/core/src/utils/overlays.ts
View File

@ -12,11 +12,7 @@ export type Requires<K extends string> = {
export function createOverlay
<T extends HTMLIonOverlayElement & Requires<keyof B>, B>
(tagName: string, opts: B): Promise<T> {
// create ionic's wrapping ion-alert component
const element = document.createElement(tagName) as T;
// give this alert a unique id
(element: T, opts: B): Promise<T> {
element.overlayId = lastId++;
// convert the passed in overlay options into props