javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(angular): detach hidden pages from change detection

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-12-03 19:48:12 +01:00
committed by Manu MA
parent 7ba94900bb
commit 959ce65323
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
angular/src/directives/navigation/stack-controller.ts
View File

@ -106,9 +106,8 @@ export class StackController {
const element = view.element;
element.setAttribute('aria-hidden', 'true');
element.classList.add('ion-page-hidden');
// view.ref.changeDetectorRef.detach();
view.ref.changeDetectorRef.detach();
}
this.viewsSnapshot = views.slice();
}
@ -133,6 +132,9 @@ export class StackController {
this.skipTransition = false;
return;
}
if (enteringView) {
enteringView.ref.changeDetectorRef.reattach();
}
const enteringEl = enteringView ? enteringView.element : undefined;
const leavingEl = leavingView ? leavingView.element : undefined;
const containerEl = this.containerEl;