From 959ce65323b399e52cbb93932c63b95474d88caf Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Mon, 3 Dec 2018 19:48:12 +0100 Subject: [PATCH] perf(angular): detach hidden pages from change detection --- angular/src/directives/navigation/stack-controller.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/angular/src/directives/navigation/stack-controller.ts b/angular/src/directives/navigation/stack-controller.ts index fd75849049..3f48e1763e 100644 --- a/angular/src/directives/navigation/stack-controller.ts +++ b/angular/src/directives/navigation/stack-controller.ts @@ -106,9 +106,8 @@ export class StackController { const element = view.element; element.setAttribute('aria-hidden', 'true'); element.classList.add('ion-page-hidden'); - // view.ref.changeDetectorRef.detach(); + view.ref.changeDetectorRef.detach(); } - this.viewsSnapshot = views.slice(); } @@ -133,6 +132,9 @@ export class StackController { this.skipTransition = false; return; } + if (enteringView) { + enteringView.ref.changeDetectorRef.reattach(); + } const enteringEl = enteringView ? enteringView.element : undefined; const leavingEl = leavingView ? leavingView.element : undefined; const containerEl = this.containerEl;