javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): fix async deadlock

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-10-14 11:25:45 -05:00
parent b9c03e39d4
commit 905c7dbd1a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/components/tabs/tabs.tsx
View File

@@ -64,7 +64,7 @@ export class Tabs implements NavOutlet {
}
this.userTabbarEl = this.el.querySelector('ion-tabbar') || undefined;
await this.initTabs();
this.initTabs();
this.ionNavWillLoad.emit();
this.componentWillUpdate();
@@ -172,11 +172,12 @@ export class Tabs implements NavOutlet {
tab.btnId = 'tab-' + id;
tab.id = 'tabpanel-' + id;
});
return Promise.all(tabs.map(tab => tab.componentOnReady()));
}
private async initSelect(): Promise<void> {
const tabs = this.tabs;
// wait for all tabs to be ready
await Promise.all(tabs.map(tab => tab.componentOnReady()));
if (this.useRouter) {
if (Build.isDev) {
const tab = tabs.find(t => t.selected);