javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Cleanups minus destroy stuff

Browse Source
This commit is contained in:
Max Lynch
2014-01-07 18:00:52 -06:00
parent 67488fa403
commit 8673bf6114
3 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dist/js/ionic-angular.js vendored
View File

@@ -25870,14 +25870,6 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture'])
}
$element.append(transclude($scope));
$scope.$on('$destroy', function () {
if (['left', 'right'].indexOf($scope.side) > -1) {
delete sideMenuCtrl[$scope.side].isEnabled;
delete sideMenuCtrl[$scope.side].pushDown;
delete sideMenuCtrl[$scope.side].bringUp;
}
});
};
}
};

8
js/ext/angular/src/directive/ionicSideMenu.js vendored
View File

@@ -147,14 +147,6 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture'])
}
$element.append(transclude($scope));
$scope.$on('$destroy', function () {
if (['left', 'right'].indexOf($scope.side) > -1) {
delete sideMenuCtrl[$scope.side].isEnabled;
delete sideMenuCtrl[$scope.side].pushDown;
delete sideMenuCtrl[$scope.side].bringUp;
}
});
};
}
};

7
js/ext/angular/test/directive/ionicSideMenu.unit.js
View File

@@ -79,11 +79,4 @@ describe('Ionic Side Menu Directive', function () {
expect(sideMenuCtrl.left.pushDown).not.toBe(undefined);
expect(sideMenuCtrl.left.bringUp).not.toBe(undefined);
});
it('Should remove the attributes it sets on the controller', function () {
scope.$destroy();
expect(sideMenuCtrl.left.isEnabled).toBe(undefined);
expect(sideMenuCtrl.left.pushDown).toBe(undefined);
expect(sideMenuCtrl.left.bringUp).toBe(undefined);
});
});