javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 20:33:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4971 from 3dd13/remove-css-classes-when-ion-icon-on-destroy

Browse Source 
fix(icon): add ngOnDestroy to ion-icon and remove added css class
This commit is contained in:
Adam Bradley
2016-01-15 08:41:41 -06:00
parent 42c24bbff8 a00e34254b
commit 7e98c102d5
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ionic/components/icon/icon.ts
View File

@ -54,7 +54,7 @@ export class Icon {
private _md: string = '';
private _css: string = '';
mode: string;
constructor(
config: Config,
private _elementRef: ElementRef,
@ -70,11 +70,20 @@ export class Icon {
}
}
/**
* @private
*/
ngOnDestroy() {
if (this._css) {
this._renderer.setElementClass(this._elementRef, this._css, false);
}
}
@Input()
get name() {
return this._name;
}
set name(val) {
if (!(/^md-|^ios-|^logo-/.test(val))) {
// this does not have one of the defaults
@ -85,7 +94,7 @@ export class Icon {
this.update();
}
@Input()
@Input()
get ios(): string {
return this._ios;
}