javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 23:58:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(tslint): fixes all JS linting issues

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-02-27 18:28:34 +01:00
parent 465975228c
commit 7a0f2769b1
30 changed files with 67 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/components/action-sheet-controller/action-sheet-controller.tsx
View File

@ -1,6 +1,6 @@
import { Component, Listen, Method } from '@stencil/core';
import { ActionSheetEvent, ActionSheetOptions, OverlayController } from '../../index';
import { createOverlay, getTopOverlay, dismissOverlay, removeLastOverlay } from '../../utils/overlays';
import { createOverlay, dismissOverlay, getTopOverlay, removeLastOverlay } from '../../utils/overlays';
@Component({
tag: 'ion-action-sheet-controller'

6
packages/core/src/components/action-sheet/action-sheet.tsx
View File

@ -3,7 +3,7 @@ import { Animation, AnimationBuilder, Config, CssClassMap, DomController, Overla
import { domControllerAsync } from '../../utils/helpers';
import { createThemedClasses, getClassMap } from '../../utils/theme';
import { OverlayInterface, BACKDROP, overlayAnimation } from '../../utils/overlays';
import { BACKDROP, OverlayInterface, overlayAnimation } from '../../utils/overlays';
import iosEnterAnimation from './animations/ios.enter';
import iosLeaveAnimation from './animations/ios.leave';
@ -139,7 +139,7 @@ export class ActionSheet implements OverlayInterface {
*/
@Method()
present(): Promise<void> {
if(this.presented) {
if (this.presented) {
return Promise.reject('overlay already presented');
}
this.presented = true;
@ -162,7 +162,7 @@ export class ActionSheet implements OverlayInterface {
*/
@Method()
dismiss(data?: any, role?: string) {
if(!this.presented) {
if (!this.presented) {
return Promise.reject('overlay is not presented');
}
this.presented = false;

2
packages/core/src/components/alert-controller/alert-controller.tsx
View File

@ -1,6 +1,6 @@
import { Component, Listen, Method } from '@stencil/core';
import { AlertEvent, AlertOptions, OverlayController } from '../../index';
import { createOverlay, removeLastOverlay, dismissOverlay, getTopOverlay } from '../../utils/overlays';
import { createOverlay, dismissOverlay, getTopOverlay, removeLastOverlay } from '../../utils/overlays';
@Component({
tag: 'ion-alert-controller'

12
packages/core/src/components/alert/alert.tsx
View File

@ -1,8 +1,8 @@
import { Component, Element, Event, EventEmitter, Listen, Method, Prop } from '@stencil/core';
import { Animation, AnimationBuilder, Config, CssClassMap, DomController, OverlayDismissEvent, OverlayDismissEventDetail } from '../../index';
import { domControllerAsync, autoFocus } from '../../utils/helpers';
import { autoFocus, domControllerAsync } from '../../utils/helpers';
import { createThemedClasses, getClassMap } from '../../utils/theme';
import { OverlayInterface, BACKDROP, overlayAnimation } from '../../utils/overlays';
import { BACKDROP, OverlayInterface, overlayAnimation } from '../../utils/overlays';
import iosEnterAnimation from './animations/ios.enter';
import iosLeaveAnimation from './animations/ios.leave';
@ -146,7 +146,7 @@ export class Alert implements OverlayInterface {
*/
@Method()
present(): Promise<void> {
if(this.presented) {
if (this.presented) {
return Promise.reject('overlay already presented');
}
this.presented = true;
@ -169,7 +169,7 @@ export class Alert implements OverlayInterface {
*/
@Method()
dismiss(data?: any, role?: string) {
if(!this.presented) {
if (!this.presented) {
return Promise.reject('overlay is not presented');
}
this.presented = false;
@ -282,7 +282,7 @@ export class Alert implements OverlayInterface {
{i.label}
</div>
</div>
{this.mode==="md" ? <ion-ripple-effect /> : null}
{this.mode === 'md' ? <ion-ripple-effect /> : null}
</button>
))}
</div>
@ -302,7 +302,7 @@ export class Alert implements OverlayInterface {
{i.label}
</div>
</div>
{this.mode==="md" ? <ion-ripple-effect /> : null}
{this.mode === 'md' ? <ion-ripple-effect /> : null}
</button>
))}
</div>

4
packages/core/src/components/backdrop/backdrop.tsx
View File

@ -73,7 +73,7 @@ function registerBackdrop(backdrop: any) {
function unregisterBackdrop(backdrop: any) {
activeBackdrops.delete(backdrop);
if(activeBackdrops.size === 0) {
if (activeBackdrops.size === 0) {
document.body.classList.remove(BACKDROP_NO_SCROLL);
}
}
}

2
packages/core/src/components/gesture-controller/gesture-controller-utils.ts
View File

@ -1,4 +1,4 @@
import { GestureController } from "./gesture-controller";
import { GestureController } from './gesture-controller';
export class GestureDelegate {
private ctrl: GestureController|null;

2
packages/core/src/components/gesture-controller/gesture-controller.tsx
View File

@ -1,5 +1,5 @@
import { Component, Event, EventEmitter, Method } from '@stencil/core';
import { GestureConfig, GestureDelegate, BlockerConfig, BlockerDelegate } from './gesture-controller-utils';
import { BlockerConfig, BlockerDelegate, GestureConfig, GestureDelegate } from './gesture-controller-utils';
@Component({

8
packages/core/src/components/gesture-controller/test/gesture-controller.spec.tsx
View File

@ -241,7 +241,7 @@ describe('gesture controller', () => {
describe('BlockerDelegate', () => {
it('create one', async () => {
const c = new GestureController();
const b = await c.createBlocker({
const b = c.createBlocker({
disableScroll: true,
disable: ['event1', 'event2', 'event3', 'event4']
});
@ -251,7 +251,7 @@ describe('gesture controller', () => {
expect(b['ctrl']).toEqual(c);
expect(b['id']).toEqual(1);
const b2 = await c.createBlocker({
const b2 = c.createBlocker({
disable: ['event2', 'event3', 'event4', 'event5']
});
@ -314,11 +314,11 @@ describe('gesture controller', () => {
const g2 = await c.create({ name: 'goback2' });
expect(g2.canStart()).toEqual(true);
const g3 = await c.createBlocker({
const g3 = c.createBlocker({
disable: ['range', 'goback', 'something']
});
const g4 = await c.createBlocker({
const g4 = c.createBlocker({
disable: ['range']
});

2
packages/core/src/components/gesture/gesture.tsx
View File

@ -1,6 +1,6 @@
import { Component, Event, EventEmitter, EventListenerEnable, Listen, Prop, Watch } from '@stencil/core';
import { ElementRef, assert, now, updateDetail } from '../../utils/helpers';
import { DomController, BlockerDelegate, GestureDelegate, BlockerConfig } from '../../index';
import { BlockerConfig, BlockerDelegate, DomController, GestureDelegate } from '../../index';
import { BLOCK_ALL } from '../gesture-controller/gesture-controller-utils';
import { PanRecognizer } from './recognizers';

8
packages/core/src/components/input-shims/hacks/common.ts
View File

@ -1,10 +1,10 @@
const RELOCATED_KEY= '$ionRelocated';
const RELOCATED_KEY = '$ionRelocated';
export function relocateInput(
componentEl: HTMLElement,
inputEl: HTMLInputElement,
shouldRelocate: boolean,
inputRelativeY: number = 0
inputRelativeY = 0
) {
if ((componentEl as any)[RELOCATED_KEY] === shouldRelocate) {
return;
@ -22,7 +22,7 @@ export function relocateInput(
// We hide the focused input (with the visible caret) invisiable by making it scale(0),
cloneInputComponent(componentEl, inputEl);
const tx = document.dir === 'rtl' ? 9999 : -9999;
inputEl.style.transform= `translate3d(${tx}px,${inputRelativeY}px,0)`;
inputEl.style.transform = `translate3d(${tx}px,${inputRelativeY}px,0)`;
// TODO
// inputEle.style.opacity = '0';
} else {
@ -79,8 +79,6 @@ function cloneInputComponent(componentEl: HTMLElement, inputEl: HTMLInputElement
const clonedInputEl = document.createElement('input');
clonedInputEl.classList.add(...Array.from(inputEl.classList));
// Object.assign(clonedInputEl, input);
//const clonedInputEl = <HTMLInputElement>inputEl.cloneNode(false);
clonedInputEl.value = inputEl.value;
clonedInputEl.type = inputEl.type;
clonedInputEl.placeholder = inputEl.placeholder;

6
packages/core/src/components/input-shims/hacks/hide-caret.ts
View File

@ -1,9 +1,9 @@
import { isFocused, relocateInput } from "./common";
import { isFocused, relocateInput } from './common';
export default function enableHideCaretOnScroll(componentEl: HTMLElement, inputEl: HTMLInputElement, scrollEl: HTMLIonScrollElement) {
if(!scrollEl || !inputEl) {
return () => {};
if (!scrollEl || !inputEl) {
return () => { return; };
}
console.debug('Input: enableHideCaretOnScroll');

2
packages/core/src/components/input-shims/hacks/input-blurring.ts
View File

@ -1,4 +1,4 @@
import { App } from "../../..";
import { App } from '../../..';
const SKIP_BLURRING = ['INPUT', 'TEXTAREA', 'ION-INPUT', 'ION-TEXTAREA'];

6
packages/core/src/components/input-shims/hacks/scroll-assist.ts
View File

@ -1,6 +1,6 @@
import { pointerCoord } from "../../../utils/helpers";
import { relocateInput, isFocused } from "./common";
import { getScrollData } from "./scroll-data";
import { pointerCoord } from '../../../utils/helpers';
import { isFocused, relocateInput } from './common';
import { getScrollData } from './scroll-data';
export default function enableScrollAssist(

2
packages/core/src/components/input-shims/hacks/scroll-padding.ts
View File

@ -40,6 +40,6 @@ function setScrollPadding(input: HTMLElement, keyboardHeight: number) {
} else {
(el as any)[PADDING_TIMER_KEY] = setTimeout(() => {
el.style.paddingBottom = '';
}, 120)
}, 120);
}
}

2
packages/core/src/components/input-shims/hacks/wip.ts
View File

@ -17,4 +17,4 @@
// return () => {
// inputEl.removeEventListener('focus', onFocus);
// };
// }
// }

14
packages/core/src/components/input-shims/input-shims.tsx
View File

@ -1,10 +1,10 @@
import { Component, Listen, Prop } from "@stencil/core";
import { App, Config } from "../..";
import { Component, Listen, Prop } from '@stencil/core';
import { App, Config } from '../..';
import enableHideCaretOnScroll from "./hacks/hide-caret";
import enableInputBlurring from "./hacks/input-blurring";
import enableScrollAssist from "./hacks/scroll-assist";
import enableScrollPadding from "./hacks/scroll-padding";
import enableHideCaretOnScroll from './hacks/hide-caret';
import enableInputBlurring from './hacks/input-blurring';
import enableScrollAssist from './hacks/scroll-assist';
import enableScrollPadding from './hacks/scroll-padding';
const INPUT_BLURRING = true;
const SCROLL_ASSIST = true;
@ -45,7 +45,7 @@ export class InputShims {
// At this point we need to look for all the ion-inputs not registered yet
// and register them.
const inputs = Array.from(document.querySelectorAll('ion-input'));
for (let input of inputs) {
for (const input of inputs) {
this.registerInput(input);
}
this.didLoad = true;

2
packages/core/src/components/input/input.tsx
View File

@ -1,4 +1,4 @@
import { Component, Event, EventEmitter, Prop, Watch, Element } from '@stencil/core';
import { Component, Element, Event, EventEmitter, Prop, Watch } from '@stencil/core';
import { debounceEvent } from '../../utils/helpers';
import { createThemedClasses } from '../../utils/theme';

6
packages/core/src/components/loading/loading.tsx
View File

@ -7,7 +7,7 @@ import iosEnterAnimation from './animations/ios.enter';
import iosLeaveAnimation from './animations/ios.leave';
import mdEnterAnimation from './animations/md.enter';
import mdLeaveAnimation from './animations/md.leave';
import { OverlayInterface, BACKDROP, overlayAnimation } from '../../utils/overlays';
import { BACKDROP, OverlayInterface, overlayAnimation } from '../../utils/overlays';
@Component({
tag: 'ion-loading',
@ -152,7 +152,7 @@ export class Loading implements OverlayInterface {
*/
@Method()
present(): Promise<void> {
if(this.presented) {
if (this.presented) {
return Promise.reject('overlay already presented');
}
this.presented = true;
@ -182,7 +182,7 @@ export class Loading implements OverlayInterface {
*/
@Method()
dismiss(data?: any, role?: string) {
if(!this.presented) {
if (!this.presented) {
return Promise.reject('overlay is not presented');
}
this.presented = false;

2
packages/core/src/components/menu-button/menu-button.tsx
View File

@ -55,7 +55,7 @@ export class MenuButton {
return (
<ion-menu-toggle menu={this.menu} autoHide={this.autoHide}>
<ion-button>
<ion-icon slot="icon-only" name={menuIcon}></ion-icon>
<ion-icon slot='icon-only' name={menuIcon}></ion-icon>
</ion-button>
</ion-menu-toggle>
);

2
packages/core/src/components/menu/menu.tsx
View File

@ -490,4 +490,4 @@ export interface MenuChangeEvent {
export interface MenuChangeEventDetail {
disabled: boolean;
open: boolean;
}
}

6
packages/core/src/components/modal/modal.tsx
View File

@ -4,7 +4,7 @@ import { Animation, AnimationBuilder, Config, DomController, FrameworkDelegate,
import { DomFrameworkDelegate } from '../../utils/dom-framework-delegate';
import { domControllerAsync } from '../../utils/helpers';
import { createThemedClasses } from '../../utils/theme';
import { OverlayInterface, BACKDROP, overlayAnimation } from '../../utils/overlays';
import { BACKDROP, OverlayInterface, overlayAnimation } from '../../utils/overlays';
import iosEnterAnimation from './animations/ios.enter';
import iosLeaveAnimation from './animations/ios.leave';
@ -149,7 +149,7 @@ export class Modal implements OverlayInterface {
*/
@Method()
present(): Promise<void> {
if(this.presented) {
if (this.presented) {
return Promise.reject('overlay already presented');
}
this.presented = true;
@ -187,7 +187,7 @@ export class Modal implements OverlayInterface {
*/
@Method()
dismiss(data?: any, role?: string) {
if(!this.presented) {
if (!this.presented) {
return Promise.reject('overlay is not presented');
}
this.presented = false;

3
packages/core/src/components/nav/nav.tsx
View File

@ -1127,7 +1127,8 @@ export function updateNavStacks(enteringView: ViewController, leavingView: ViewC
return Promise.all(destroyQueuePromises);
}
return null;
})/*.then(() => {
});
/* .then(() => {
// set which animation it should use if it wasn't set yet
if (ti.requiresTransition && !ti.opts.animation) {
ti.opts.animation = isDef(ti.removeStart)

2
packages/core/src/components/picker-controller/picker-controller.tsx
View File

@ -1,6 +1,6 @@
import { Component, Listen, Method } from '@stencil/core';
import { OverlayController, PickerEvent, PickerOptions } from '../../index';
import { createOverlay, getTopOverlay, removeLastOverlay, dismissOverlay } from '../../utils/overlays';
import { createOverlay, dismissOverlay, getTopOverlay, removeLastOverlay } from '../../utils/overlays';
@Component({

4
packages/core/src/components/picker/picker.tsx
View File

@ -158,7 +158,7 @@ export class Picker implements OverlayInterface {
*/
@Method()
present(): Promise<void> {
if(this.presented) {
if (this.presented) {
return Promise.reject('overlay already presented');
}
this.presented = true;
@ -194,7 +194,7 @@ export class Picker implements OverlayInterface {
*/
@Method()
dismiss(data?: any, role?: string) {
if(!this.presented) {
if (!this.presented) {
return Promise.reject('overlay is not presented');
}
this.presented = false;

6
packages/core/src/components/popover/animations/ios.enter.ts
View File

@ -81,9 +81,9 @@ export default function iosEnterAnimation(Animation: Animation, baseEl: HTMLElem
(targetTop - contentHeight) > 0
) {
arrowCSS.top = targetTop - (arrowHeight + 1);
console.log(arrowCSS)
console.log(targetTop)
console.log(contentHeight)
console.log(arrowCSS);
console.log(targetTop);
console.log(contentHeight);
popoverCSS.top = targetTop - contentHeight - (arrowHeight - 1);
baseEl.className = baseEl.className + ' popover-bottom';

6
packages/core/src/components/popover/popover.tsx
View File

@ -4,7 +4,7 @@ import { Animation, AnimationBuilder, Config, DomController, FrameworkDelegate,
import { DomFrameworkDelegate } from '../../utils/dom-framework-delegate';
import { domControllerAsync } from '../../utils/helpers';
import { createThemedClasses } from '../../utils/theme';
import { OverlayInterface, BACKDROP, overlayAnimation } from '../../utils/overlays';
import { BACKDROP, OverlayInterface, overlayAnimation } from '../../utils/overlays';
import iosEnterAnimation from './animations/ios.enter';
import iosLeaveAnimation from './animations/ios.leave';
@ -157,7 +157,7 @@ export class Popover implements OverlayInterface {
*/
@Method()
present(): Promise<void> {
if(this.presented) {
if (this.presented) {
return Promise.reject('overlay already presented');
}
this.presented = true;
@ -197,7 +197,7 @@ export class Popover implements OverlayInterface {
*/
@Method()
dismiss(data?: any, role?: string) {
if(!this.presented) {
if (!this.presented) {
return Promise.reject('overlay is not presented');
}
this.presented = false;

4
packages/core/src/components/scroll/scroll.tsx
View File

@ -1,5 +1,5 @@
import { Component, Element, Event, EventEmitter, EventListenerEnable, Listen, Method, Prop } from '@stencil/core';
import { Config, DomController, GestureDetail, GestureDelegate } from '../../index';
import { Config, DomController, GestureDelegate, GestureDetail } from '../../index';
@Component({
@ -65,7 +65,7 @@ export class Scroll {
priority: 100,
disableScroll: false,
}).then((gesture) => {
this.gesture = gesture
this.gesture = gesture;
});
}

2
packages/core/src/components/select/select.tsx
View File

@ -522,7 +522,7 @@ export class Select {
onBlur={this.onBlur.bind(this)}
class='select-cover'>
<slot></slot>
{this.mode==="md" ? <ion-ripple-effect /> : null}
{this.mode === 'md' ? <ion-ripple-effect /> : null}
</button>,
<input type='hidden' name={this.name} value={this.value}/>
];

4
packages/core/src/components/toast/toast.tsx
View File

@ -144,7 +144,7 @@ export class Toast implements OverlayInterface {
*/
@Method()
present(): Promise<void> {
if(this.presented) {
if (this.presented) {
return Promise.reject('overlay already presented');
}
this.presented = true;
@ -168,7 +168,7 @@ export class Toast implements OverlayInterface {
*/
@Method()
dismiss(data?: any, role?: string) {
if(!this.presented) {
if (!this.presented) {
return Promise.reject('overlay is not presented');
}
this.presented = false;

6
packages/core/src/utils/overlays.ts
View File

@ -1,5 +1,5 @@
import { AnimationBuilder, Animation } from "..";
import { playAnimationAsync } from "./helpers";
import { Animation, AnimationBuilder } from '..';
import { playAnimationAsync } from './helpers';
let lastId = 1;
@ -8,7 +8,7 @@ let lastId = 1;
*/
export type Requires<K extends string> = {
[P in K]: any;
}
};
export function createOverlay
<T extends HTMLIonOverlayElement & Requires<keyof B>, B>