javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 10:01:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): name prop is not longer used

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-10-31 17:35:04 +01:00
parent 0faa355139
commit 6d11cc15f8
4 changed files with 1 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
angular/src/directives/proxies.ts
View File

@ -891,7 +891,7 @@ export class TabButton {
} }
export declare interface Tabs extends StencilComponents<'IonTabs'> {} export declare interface Tabs extends StencilComponents<'IonTabs'> {}
@Component({ selector: 'ion-tabs', changeDetection: ChangeDetectionStrategy.OnPush, encapsulation: ViewEncapsulation.None, template: '<ng-content></ng-content>', inputs: ['name'] }) @Component({ selector: 'ion-tabs', changeDetection: ChangeDetectionStrategy.OnPush, encapsulation: ViewEncapsulation.None, template: '<ng-content></ng-content>' })
export class Tabs { export class Tabs {
ionChange: EventEmitter<CustomEvent>; ionChange: EventEmitter<CustomEvent>;
ionNavWillLoad: EventEmitter<CustomEvent>; ionNavWillLoad: EventEmitter<CustomEvent>;
@ -902,7 +902,6 @@ export class Tabs {
c.detach(); c.detach();
const el = r.nativeElement; const el = r.nativeElement;
proxyMethods(this, el, ['select', 'setRouteId', 'getRouteId', 'getTab', 'getSelected']); proxyMethods(this, el, ['select', 'setRouteId', 'getRouteId', 'getTab', 'getSelected']);
proxyInputs(this, el, ['name']);
proxyOutputs(this, el, ['ionChange', 'ionNavWillLoad', 'ionNavWillChange', 'ionNavDidChange']); proxyOutputs(this, el, ['ionChange', 'ionNavWillLoad', 'ionNavWillChange', 'ionNavDidChange']);
} }
} }

8
core/src/components.d.ts vendored
View File

@ -4586,20 +4586,12 @@ export namespace Components {
*/ */
'getTab': (tab: string | HTMLIonTabElement) => Promise<HTMLIonTabElement | undefined>; 'getTab': (tab: string | HTMLIonTabElement) => Promise<HTMLIonTabElement | undefined>;
/** /**
* A unique name for the tabs.
*/
'name'?: string;
/**
* Index or the Tab instance, of the tab to select. * Index or the Tab instance, of the tab to select.
*/ */
'select': (tab: string | HTMLIonTabElement) => Promise<boolean>; 'select': (tab: string | HTMLIonTabElement) => Promise<boolean>;
'setRouteId': (id: string) => Promise<RouteWrite>; 'setRouteId': (id: string) => Promise<RouteWrite>;
} }
interface IonTabsAttributes extends StencilHTMLAttributes { interface IonTabsAttributes extends StencilHTMLAttributes {
/**
* A unique name for the tabs.
*/
'name'?: string;
/** /**
* Emitted when the tab changes. * Emitted when the tab changes.
*/ */

7
core/src/components/tabs/readme.md
View File

@ -33,13 +33,6 @@ direct children of `ion-tabs`, like this:
<!-- Auto Generated Below --> <!-- Auto Generated Below -->
## Properties
| Property | Attribute | Description | Type |
| -------- | --------- | --------------------------- | --------------------- |
| `name` | `name` | A unique name for the tabs. | `string \| undefined` |
## Events ## Events
| Event | Detail | Description | | Event | Detail | Description |

5
core/src/components/tabs/tabs.tsx
View File

@ -21,11 +21,6 @@ export class Tabs implements NavOutlet {
@Prop({ context: 'config' }) config!: Config; @Prop({ context: 'config' }) config!: Config;
@Prop({ context: 'document' }) doc!: Document; @Prop({ context: 'document' }) doc!: Document;
/**
* A unique name for the tabs.
*/
@Prop() name?: string;
/** /**
* Emitted when the tab changes. * Emitted when the tab changes.
*/ */