From 6d11cc15f8503c5e18ee9d7574e45e766851571d Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Wed, 31 Oct 2018 17:35:04 +0100 Subject: [PATCH] fix(tabs): name prop is not longer used --- angular/src/directives/proxies.ts | 3 +-- core/src/components.d.ts | 8 -------- core/src/components/tabs/readme.md | 7 ------- core/src/components/tabs/tabs.tsx | 5 ----- 4 files changed, 1 insertion(+), 22 deletions(-) diff --git a/angular/src/directives/proxies.ts b/angular/src/directives/proxies.ts index 90d1d50ba5..e47ec382d6 100644 --- a/angular/src/directives/proxies.ts +++ b/angular/src/directives/proxies.ts @@ -891,7 +891,7 @@ export class TabButton { } export declare interface Tabs extends StencilComponents<'IonTabs'> {} -@Component({ selector: 'ion-tabs', changeDetection: ChangeDetectionStrategy.OnPush, encapsulation: ViewEncapsulation.None, template: '', inputs: ['name'] }) +@Component({ selector: 'ion-tabs', changeDetection: ChangeDetectionStrategy.OnPush, encapsulation: ViewEncapsulation.None, template: '' }) export class Tabs { ionChange: EventEmitter; ionNavWillLoad: EventEmitter; @@ -902,7 +902,6 @@ export class Tabs { c.detach(); const el = r.nativeElement; proxyMethods(this, el, ['select', 'setRouteId', 'getRouteId', 'getTab', 'getSelected']); - proxyInputs(this, el, ['name']); proxyOutputs(this, el, ['ionChange', 'ionNavWillLoad', 'ionNavWillChange', 'ionNavDidChange']); } } diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 060cd975cd..94927c2521 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -4586,20 +4586,12 @@ export namespace Components { */ 'getTab': (tab: string | HTMLIonTabElement) => Promise; /** - * A unique name for the tabs. - */ - 'name'?: string; - /** * Index or the Tab instance, of the tab to select. */ 'select': (tab: string | HTMLIonTabElement) => Promise; 'setRouteId': (id: string) => Promise; } interface IonTabsAttributes extends StencilHTMLAttributes { - /** - * A unique name for the tabs. - */ - 'name'?: string; /** * Emitted when the tab changes. */ diff --git a/core/src/components/tabs/readme.md b/core/src/components/tabs/readme.md index 533ff6b701..6034028aa6 100644 --- a/core/src/components/tabs/readme.md +++ b/core/src/components/tabs/readme.md @@ -33,13 +33,6 @@ direct children of `ion-tabs`, like this: -## Properties - -| Property | Attribute | Description | Type | -| -------- | --------- | --------------------------- | --------------------- | -| `name` | `name` | A unique name for the tabs. | `string \| undefined` | - - ## Events | Event | Detail | Description | diff --git a/core/src/components/tabs/tabs.tsx b/core/src/components/tabs/tabs.tsx index 683e37febb..f4e973c378 100644 --- a/core/src/components/tabs/tabs.tsx +++ b/core/src/components/tabs/tabs.tsx @@ -21,11 +21,6 @@ export class Tabs implements NavOutlet { @Prop({ context: 'config' }) config!: Config; @Prop({ context: 'document' }) doc!: Document; - /** - * A unique name for the tabs. - */ - @Prop() name?: string; - /** * Emitted when the tab changes. */