fix(radio-group): prevent DOMException and NotFoundError when filtering radios (#30958)

resolves #30279 resolves #30359

## What is the current behavior?
While Ionic's `stencil.config.ts` sets `experimentalSlotFixes: true`,
the fixes never get applied at runtime. Ionic is using an external
runtime, so Ionic components import `defineCustomElement` from
`@stencil/core/internal/client` at runtime and this code has no
awareness of the project's stencil configuration.

This leads to a `NotFoundError` (Failed to execute 'removeChild' on
'Node') when filtering or dynamically removing radios in an
`ion-radio-group`. The error occurs because `ion-radio-group` wraps its
slotted content in an internal `<div>`.

## What is the new behavior?
By setting `externalRuntime: false`, Stencil generates a
project-specific file with `defineCustomElement` that components import.
This file has the project's build settings baked in, correctly applying
slot fixes.

Additionally, the internal wrapper `<div>` around the slotted content in
`ion-radio-group` is removed. With slot fixes correctly applied and the
wrapper removed, radios can be filtered or dynamically removed without
triggering `NotFoundError` or `DOMExceptions`.

## Does this introduce a breaking change?

- [ ] Yes
- [X] No

## Other information
External Runtime is enabled by default and designed for projects that
import Stencil components from multiple sources. This is flawed because
those components will not be running with the runtime settings for which
they were made.
This commit is contained in:
OS-jacobbell
2026-02-19 10:03:48 -07:00
committed by GitHub
parent 70b1237823
commit 682a17ebb7
3 changed files with 3 additions and 13 deletions

View File

@@ -8,10 +8,6 @@ ion-radio-group {
vertical-align: top;
}
.radio-group-wrapper {
display: inline;
}
// Radio Group: Top
// --------------------------------------------------

View File

@@ -353,14 +353,7 @@ export class RadioGroup implements ComponentInterface {
class={mode}
>
{this.renderHintText()}
{/*
TODO(FW-6279): Wrapping the slot in a div is a workaround due to a
Stencil issue. Without the wrapper, the children radio will fire the
blur event on focus, instead of waiting for them to be blurred.
*/}
<div class="radio-group-wrapper">
<slot></slot>
</div>
<slot></slot>
</Host>
);
}

View File

@@ -226,7 +226,8 @@ export const config: Config = {
dest: 'components',
warn: true
}],
includeGlobalScripts: false
includeGlobalScripts: false,
externalRuntime: false,
},
{
type: 'docs-json',