javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(alert): update comments

Browse Source
This commit is contained in:
Maria Hutt
2025-03-28 14:50:11 -07:00
parent 6a819d5eeb
commit 62cf80c433
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/api.txt
View File

@ -100,12 +100,15 @@ ion-alert,scoped
ion-alert,prop,animated,boolean,true,false,false
ion-alert,prop,backdropDismiss,boolean,true,false,false
ion-alert,prop,buttons,(string | AlertButton)[],[],false,false
ion-alert,prop,component,Function | HTMLElement | null | string | undefined,undefined,false,false
ion-alert,prop,componentProps,undefined | { [key: string]: any; },undefined,false,false
ion-alert,prop,cssClass,string | string[] | undefined,undefined,false,false
ion-alert,prop,enterAnimation,((baseEl: any, opts?: any) => Animation) | undefined,undefined,false,false
ion-alert,prop,header,string | undefined,undefined,false,false
ion-alert,prop,htmlAttributes,undefined | { [key: string]: any; },undefined,false,false
ion-alert,prop,inputs,AlertInput[],[],false,false
ion-alert,prop,isOpen,boolean,false,false,false
ion-alert,prop,keepContentsMounted,boolean,false,false,false
ion-alert,prop,keyboardClose,boolean,true,false,false
ion-alert,prop,leaveAnimation,((baseEl: any, opts?: any) => Animation) | undefined,undefined,false,false
ion-alert,prop,message,IonicSafeString | string | undefined,undefined,false,false

2
core/src/components.d.ts vendored
View File

@ -5115,7 +5115,7 @@ declare namespace LocalJSX {
*/
"onIonAlertWillPresent"?: (event: IonAlertCustomEvent<void>) => void;
/**
* Emitted before the alert has presented, but after the component has been mounted in the DOM. This event exists for ion-alert to resolve an issue with the alert and the lazy build, that the transition is unable to get the correct dimensions of the alert with auto sizing. This is not required for other overlays, since the existing overlay transitions are not effected by auto sizing content.
* Emitted before the modal has presented, but after the component has been mounted in the DOM. This event exists so iOS can run the entering transition properly
*/
"onIonMount"?: (event: IonAlertCustomEvent<void>) => void;
/**

19
core/src/components/alert/alert.tsx
View File

@ -386,13 +386,10 @@ export class Alert implements ComponentInterface, OverlayInterface {
}
/**
* Emitted before the alert has presented, but after the component
* Emitted before the modal has presented, but after the component
* has been mounted in the DOM.
* This event exists for ion-alert to resolve an issue with the
* alert and the lazy build, that the transition is unable to get
* the correct dimensions of the alert with auto sizing.
* This is not required for other overlays, since the existing
* overlay transitions are not effected by auto sizing content.
* This event exists so iOS can run the entering
* transition properly
*
* @internal
*/
@ -586,7 +583,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
if (dismissed) {
/**
* If using popover inline
* If using alert inline
* we potentially need to use the coreDelegate
* so that this works in vanilla JS apps
*/
@ -972,10 +969,10 @@ export class Alert implements ComponentInterface, OverlayInterface {
}
const LIFECYCLE_MAP: any = {
ionPopoverDidPresent: 'ionViewDidEnter',
ionPopoverWillPresent: 'ionViewWillEnter',
ionPopoverWillDismiss: 'ionViewWillLeave',
ionPopoverDidDismiss: 'ionViewDidLeave',
ionAlertDidPresent: 'ionViewDidEnter',
ionAlertWillPresent: 'ionViewWillEnter',
ionAlertWillDismiss: 'ionViewWillLeave',
ionAlertDidDismiss: 'ionViewDidLeave',
};
const inputClass = (input: AlertInput): CssClassMap => {