javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react-router): sort fallback params by specificity to prevent less-specific overwrites

Browse Source
This commit is contained in:
ShaneK
2026-03-11 10:44:55 -07:00
parent 640f430ecc
commit 62bd43f76b
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/react-router/src/ReactRouter/ReactRouterViewStack.tsx
View File

@@ -89,7 +89,7 @@ const getFallbackParamsFromViewItems = (
currentOutletId: string,
currentPathname: string
): RouteParams => {
const params: RouteParams = {};
const matchingViews: { params: RouteParams; pathLength: number }[] = [];
for (const otherViewItem of allViewItems) {
if (otherViewItem.outletId === currentOutletId) continue;
@@ -98,11 +98,23 @@ const getFallbackParamsFromViewItems = (
if (otherMatch?.params && Object.keys(otherMatch.params).length > 0) {
const matchedPathname = otherMatch.pathnameBase || otherMatch.pathname;
if (matchedPathname && currentPathname.startsWith(matchedPathname)) {
Object.assign(params, otherMatch.params);
matchingViews.push({
params: otherMatch.params,
pathLength: matchedPathname.length,
});
}
}
}
// Sort ascending by path length so more-specific (longer) paths are applied
// last and their params take priority over less-specific ones.
matchingViews.sort((a, b) => a.pathLength - b.pathLength);
const params: RouteParams = {};
for (const view of matchingViews) {
Object.assign(params, view.params);
}
return params;
};