javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): blank tab

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-02-16 17:30:48 +01:00
parent fb76a881fd
commit 57dd6948d4
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/core/src/components/tabs/tabs.tsx
View File

@@ -100,6 +100,7 @@ export class Tabs implements NavOutlet {
// @Listen('ionSelect')
protected tabChange(ev: CustomEvent) {
const selectedTab = ev.detail as HTMLIonTabElement;
debugger;
this.select(selectedTab);
}
@@ -107,7 +108,7 @@ export class Tabs implements NavOutlet {
* @param {number|Tab} tabOrIndex Index, or the Tab instance, of the tab to select.
*/
@Method()
select(tabOrIndex: number | HTMLIonTabElement): Promise<any> {
select(tabOrIndex: number | HTMLIonTabElement): Promise<boolean> {
const selectedTab = (typeof tabOrIndex === 'number' ? this.getByIndex(tabOrIndex) : tabOrIndex);
if (!selectedTab) {
return Promise.resolve();
@@ -124,13 +125,15 @@ export class Tabs implements NavOutlet {
return selectedTab.setActive()
.then(() => {
if (leavingTab) {
leavingTab.active = false;
}
selectedTab.selected = true;
this.selectedTab = selectedTab;
this.ionChange.emit(selectedTab);
this.ionNavChanged.emit({isPop: false});
if (leavingTab && leavingTab !== selectedTab) {
leavingTab.active = false;
this.selectedTab = selectedTab;
this.ionChange.emit(selectedTab);
this.ionNavChanged.emit({isPop: false});
return true;
}
return false;
});
}