javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: picker-column emits correct payload

Browse Source
This commit is contained in:
Liam DeBeasi
2023-12-04 10:52:01 -05:00
parent ed8cfa06fe
commit 506f42bec4
5 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/components.d.ts vendored
View File

@@ -4051,7 +4051,7 @@ declare global {
new (): HTMLIonPickerElement;
};
interface HTMLIonPickerColumnElementEventMap {
"ionChange": string | number | undefined;
"ionChange": { value: string | number | undefined };
}
interface HTMLIonPickerColumnElement extends Components.IonPickerColumn, HTMLStencilElement {
addEventListener<K extends keyof HTMLIonPickerColumnElementEventMap>(type: K, listener: (this: HTMLIonPickerColumnElement, ev: IonPickerColumnCustomEvent<HTMLIonPickerColumnElementEventMap[K]>) => any, options?: boolean | AddEventListenerOptions): void;
@@ -6631,7 +6631,7 @@ declare namespace LocalJSX {
/**
* Emitted when the value has changed.
*/
"onIonChange"?: (event: IonPickerColumnCustomEvent<string | number | undefined>) => void;
"onIonChange"?: (event: IonPickerColumnCustomEvent<{ value: string | number | undefined }>) => void;
/**
* The selected option in the picker.
*/

10
core/src/components/datetime/datetime.tsx
View File

@@ -1817,7 +1817,7 @@ export class Datetime implements ComponentInterface {
}}
>
{months.map((month: PickerColumnItem) => (
<ion-picker-column-option disabled={item.disabled} value={month.value}>{month.text}</ion-picker-column-option>
<ion-picker-column-option disabled={month.disabled} value={month.value}>{month.text}</ion-picker-column-option>
))}
</ion-picker-column>
);
@@ -1864,7 +1864,7 @@ export class Datetime implements ComponentInterface {
}}
>
{years.map((year: PickerColumnItem) => (
<ion-picker-column-option disabled={item.disabled} value={year.value}>{year.text}</ion-picker-column-option>
<ion-picker-column-option disabled={year.disabled} value={year.value}>{year.text}</ion-picker-column-option>
))}
</ion-picker-column>
);
@@ -1930,7 +1930,7 @@ export class Datetime implements ComponentInterface {
}}
>
{hoursData.map((hour: PickerColumnItem) => (
<ion-picker-column-option disabled={item.disabled} value={hour.value}>{hour.text}</ion-picker-column-option>
<ion-picker-column-option disabled={hour.disabled} value={hour.value}>{hour.text}</ion-picker-column-option>
))}
</ion-picker-column>
);
@@ -1962,7 +1962,7 @@ export class Datetime implements ComponentInterface {
}}
>
{minutesData.map((minute: PickerColumnItem) => (
<ion-picker-column-option disabled={item.disabled} value={minute.value}>{minute.text}</ion-picker-column-option>
<ion-picker-column-option disabled={minute.disabled} value={minute.value}>{minute.text}</ion-picker-column-option>
))}
</ion-picker-column>
);
@@ -2001,7 +2001,7 @@ export class Datetime implements ComponentInterface {
}}
>
{dayPeriodData.map((dayPeriod: PickerColumnItem) => (
<ion-picker-column-option disabled={item.disabled} value={dayPeriod.value}>{dayPeriod.text}</ion-picker-column-option>
<ion-picker-column-option disabled={dayPeriod.disabled} value={dayPeriod.value}>{dayPeriod.text}</ion-picker-column-option>
))}
</ion-picker-column>
);

4
core/src/components/picker-column/picker-column.tsx
View File

@@ -72,7 +72,7 @@ export class PickerColumn implements ComponentInterface {
/**
* Emitted when the value has changed.
*/
@Event() ionChange!: EventEmitter<string | number | undefined>;
@Event() ionChange!: EventEmitter<{ value: string | number | undefined }>;
@Watch('value')
valueChange() {
@@ -176,7 +176,7 @@ export class PickerColumn implements ComponentInterface {
}
this.value = value;
this.ionChange.emit(value);
this.ionChange.emit({ value });
}
private centerPickerItemInView = (target: HTMLElement, smooth = true, canExitInputMode = true) => {

2
packages/angular/src/directives/proxies.ts
View File

@@ -1469,7 +1469,7 @@ export declare interface IonPickerColumn extends Components.IonPickerColumn {
/**
* Emitted when the value has changed.
*/
ionChange: EventEmitter<CustomEvent<string | number | undefined>>;
ionChange: EventEmitter<CustomEvent<{ value: string | number | undefined }>>;
}

2
packages/angular/standalone/src/directives/proxies.ts
View File

@@ -1465,7 +1465,7 @@ export declare interface IonPickerColumn extends Components.IonPickerColumn {
/**
* Emitted when the value has changed.
*/
ionChange: EventEmitter<CustomEvent<string | number | undefined>>;
ionChange: EventEmitter<CustomEvent<{ value: string | number | undefined }>>;
}