javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): prevent reentering

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-02-16 20:19:03 +01:00
parent eeec3b1b5e
commit 4e7b8a21d8
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/core/src/components/tabs/tabs.tsx
View File

@@ -10,6 +10,7 @@ import { getIonApp } from '../../utils/helpers';
})
export class Tabs implements NavOutlet {
private ids = -1;
private transitioning = false;
private tabsId: number = (++tabIds);
initialized = false;
@@ -108,6 +109,9 @@ export class Tabs implements NavOutlet {
*/
@Method()
select(tabOrIndex: number | HTMLIonTabElement): Promise<boolean> {
if (this.transitioning) {
return Promise.resolve(false);
}
const selectedTab = (typeof tabOrIndex === 'number' ? this.getByIndex(tabOrIndex) : tabOrIndex);
if (!selectedTab) {
return Promise.resolve(false);
@@ -121,8 +125,9 @@ export class Tabs implements NavOutlet {
}
const leavingTab = this.selectedTab;
this.transitioning = true;
return selectedTab.setActive().then(() => {
this.transitioning = false;
selectedTab.selected = true;
if (leavingTab !== selectedTab) {
if (leavingTab) {