javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(navigation): mark as not transitioning on success in addition to '_transitionFinish', provide no

Browse Source 
mark as not transitioning on success in addition to '_transitionFinish', provide note as to why we
want it in both places
This commit is contained in:
Dan Bucholtz
2017-06-29 15:23:26 -05:00
parent 486bff036d
commit 48b3243689
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/navigation/nav-controller-base.ts
View File

@@ -223,6 +223,8 @@ export class NavControllerBase extends Ion implements NavController {
this._init = true;
this._trnsId = null;
// ensure we're not transitioning here
this.setTransitioning(false);
this._swipeBackCheck();
// let's see if there's another to kick off
this._nextTrns();
@@ -749,6 +751,8 @@ export class NavControllerBase extends Ion implements NavController {
// it's safe to enable the app again
this._app.setEnabled(true);
// mark ourselves as not transitioning - `deepLinker navchange` requires this
// TODO - probably could be resolved in a better way
this.setTransitioning(false);
if (!this.hasChild() && opts.updateUrl !== false) {