chore(): use class selectors in e2e

This commit is contained in:
Adam Bradley
2015-09-22 11:25:27 -05:00
parent 50c82a7de9
commit 3bd0b5c8ac
20 changed files with 41 additions and 40 deletions

View File

@@ -1,4 +1,4 @@
<ion-menu #menu [content]="content" id="menu">
<ion-menu #menu [content]="content">
<ion-toolbar secondary>
<ion-title>Left Menu</ion-title>
@@ -12,7 +12,7 @@
{{p.title}}
</button>
<button ion-item menu-toggle="menu" id="e2eCloseMenu">
<button ion-item menu-toggle>
Close Menu
</button>

View File

@@ -17,7 +17,7 @@
<h3>Page 1</h3>
<p>
<button id="e2eContentToggleMenu" menu-toggle>Toggle Menu</button>
<button menu-toggle>Toggle Menu</button>
</p>
<f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f>

View File

@@ -16,7 +16,7 @@
<h3>Page 2</h3>
<p>
<button menu-toggle id="e2eContentToggleMenu">Toggle Menu</button>
<button menu-toggle>Toggle Menu</button>
</p>
</ion-content>

View File

@@ -75,7 +75,7 @@ export class ContactModal {
@IonicView({
template: `
<ion-navbar *navbar><ion-title>First Page Header</ion-title><ion-nav-items primary><button id="e2eCloseMenu" (click)="closeModal()">Close</button></ion-nav-items></ion-navbar>
<ion-navbar *navbar><ion-title>First Page Header</ion-title><ion-nav-items primary><button (click)="closeModal()">Close</button></ion-nav-items></ion-navbar>
<ion-content padding>
<p>
<button (click)="push()">Push (Go to 2nd)</button>

View File

@@ -1,3 +1,4 @@
<ion-content padding>
<button id="e2eOpenModal" (click)="openModal()">Open Modal</button>
<button (click)="openModal()">Open Modal</button>
</ion-content>

View File

@@ -1,7 +1,7 @@
it('should check apple, enable/check grape, submit form', function() {
element(by.css('#e2eAppleCheckbox')).click();
element(by.css('#e2eGrapeDisabled')).click();
element(by.css('#e2eGrapeChecked')).click();
element(by.css('#e2eSubmit')).click();
element(by.css('.e2eAppleCheckbox')).click();
element(by.css('.e2eGrapeDisabled')).click();
element(by.css('.e2eGrapeChecked')).click();
element(by.css('.e2eSubmit')).click();
});

View File

@@ -8,7 +8,7 @@
<ion-list>
<ion-checkbox value="apple" checked="true" ng-control="appleCtrl" id="e2eAppleCheckbox">
<ion-checkbox value="apple" checked="true" ng-control="appleCtrl" class="e2eAppleCheckbox">
Apple, value=apple, init checked
</ion-checkbox>
@@ -33,9 +33,9 @@
</form>
<p aria-hidden="true" class="align-center">
<button (click)="toggleGrapeChecked()" outline small id="e2eGrapeChecked">Grape Checked</button>
<button (click)="toggleGrapeDisabled()" outline small id="e2eGrapeDisabled">Grape Disabled</button>
<button (click)="doSubmit($event)" outline small id="e2eSubmit">Submit</button>
<button (click)="toggleGrapeChecked()" outline small class="e2eGrapeChecked">Grape Checked</button>
<button (click)="toggleGrapeDisabled()" outline small class="e2eGrapeDisabled">Grape Disabled</button>
<button (click)="doSubmit($event)" outline small class="e2eSubmit">Submit</button>
</p>
<p aria-hidden="true" padding>

View File

@@ -1,9 +1,9 @@
it('should toggle open menu', function() {
element(by.css('#e2eContentToggleMenu')).click();
element(by.css('.e2eContentToggleMenu')).click();
});
it('should close menu', function() {
element(by.css('#e2eCloseMenu')).click();
element(by.css('.e2eCloseMenu')).click();
});

View File

@@ -12,7 +12,7 @@
{{p.title}}
</button>
<button ion-item menu-toggle no-forward-icon id="e2eCloseMenu">
<button ion-item menu-toggle no-forward-icon class="e2eCloseMenu">
Close Menu
</button>

View File

@@ -33,7 +33,7 @@
<h3>Page 1</h3>
<p>
<button id="e2eContentToggleMenu" menu-toggle>Toggle Menu</button>
<button class="e2eContentToggleMenu" menu-toggle>Toggle Menu</button>
</p>
<f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f>

View File

@@ -16,7 +16,7 @@
<h3>Page 2</h3>
<p>
<button menu-toggle id="e2eContentToggleMenu">Toggle Menu</button>
<button menu-toggle class="e2eContentToggleMenu">Toggle Menu</button>
</p>
<p>

View File

@@ -1,8 +1,8 @@
it('should open action sheet', function() {
element(by.css('#e2eOpenModal')).click();
element(by.css('.e2eOpenModal')).click();
});
it('should close with close button click', function() {
element(by.css('#e2eCloseMenu')).click();
element(by.css('.e2eCloseMenu')).click();
});

View File

@@ -75,7 +75,7 @@ export class ContactModal {
@IonicView({
template: `
<ion-navbar *navbar><ion-title>First Page Header</ion-title><ion-nav-items primary><button id="e2eCloseMenu" (click)="closeModal()">Close</button></ion-nav-items></ion-navbar>
<ion-navbar *navbar><ion-title>First Page Header</ion-title><ion-nav-items primary><button class="e2eCloseMenu" (click)="closeModal()">Close</button></ion-nav-items></ion-navbar>
<ion-content padding>
<p>
<button (click)="push()">Push (Go to 2nd)</button>

View File

@@ -1,3 +1,3 @@
<ion-content padding>
<button id="e2eOpenModal" (click)="openModal()">Open Modal</button>
<button class="e2eOpenModal" (click)="openModal()">Open Modal</button>
</ion-content>

View File

@@ -1,6 +1,6 @@
it('should open alert', function() {
element(by.css('#e2eOpenAlert')).click();
element(by.css('.e2eOpenAlert')).click();
});
@@ -10,7 +10,7 @@ it('should close alert', function() {
it('should open prompt', function() {
element(by.css('#e2eOpenPrompt')).click();
element(by.css('.e2eOpenPrompt')).click();
});
@@ -22,7 +22,7 @@ it('should close prompt', function() {
it('should open confirm', function() {
element(by.css('#e2eOpenConfirm')).click();
element(by.css('.e2eOpenConfirm')).click();
});

View File

@@ -1,9 +1,9 @@
<ion-content padding>
<button id="e2eOpenAlert" (click)="doAlert()">Alert</button>
<button id="e2eOpenPrompt" (click)="doPrompt()">Prompt</button>
<button id="e2eOpenConfirm" (click)="doConfirm()">Confirm</button>
<button class="e2eOpenAlert" (click)="doAlert()">Alert</button>
<button class="e2eOpenPrompt" (click)="doPrompt()">Prompt</button>
<button class="e2eOpenConfirm" (click)="doConfirm()">Confirm</button>
<pre>
Alert Opened: {{alertOpen}}

View File

@@ -1,4 +1,4 @@
it('should check Cherry', function() {
element(by.css('#e2eCherry')).click();
element(by.css('.e2eCherry')).click();
});

View File

@@ -16,7 +16,7 @@
Apple
</ion-radio>
<ion-radio value="banana" id="e2eBanana">
<ion-radio value="banana" class="e2eBanana">
Banana
</ion-radio>
@@ -35,7 +35,7 @@
<p aria-hidden="true" class="align-center">
<button (click)="setApple()" outline small>Select Apple</button>
<button (click)="setBanana()" outline small>Select Banana</button>
<button id="e2eCherry" (click)="setCherry()" outline small>Select Cherry</button>
<button class="e2eCherry" (click)="setCherry()" outline small>Select Cherry</button>
</p>
<p>

View File

@@ -1,11 +1,11 @@
it('should check apple via switch element click', function() {
element(by.css('#e2eAppleCheckbox .media-switch')).click();
element(by.css('.e2eAppleCheckbox .media-switch')).click();
});
it('should enable/check grape via buttons and submit form', function() {
element(by.css('#e2eGrapeDisabled')).click();
element(by.css('#e2eGrapeChecked')).click();
element(by.css('#e2eSubmit')).click();
element(by.css('.e2eGrapeDisabled')).click();
element(by.css('.e2eGrapeChecked')).click();
element(by.css('.e2eSubmit')).click();
});

View File

@@ -8,7 +8,7 @@
<ion-list>
<ion-switch value="apple" checked="true" ng-control="appleCtrl" id="e2eAppleCheckbox">
<ion-switch value="apple" checked="true" ng-control="appleCtrl" class="e2eAppleCheckbox">
Apple, value=apple, init checked
</ion-switch>
@@ -33,9 +33,9 @@
</form>
<p aria-hidden="true" class="align-center">
<button (click)="toggleGrapeChecked()" outline small id="e2eGrapeChecked">Grape Checked</button>
<button (click)="toggleGrapeDisabled()" outline small id="e2eGrapeDisabled">Grape Disabled</button>
<button (click)="doSubmit($event)" outline small id="e2eSubmit">Submit</button>
<button (click)="toggleGrapeChecked()" outline small class="e2eGrapeChecked">Grape Checked</button>
<button (click)="toggleGrapeDisabled()" outline small class="e2eGrapeDisabled">Grape Disabled</button>
<button (click)="doSubmit($event)" outline small class="e2eSubmit">Submit</button>
</p>
<p aria-hidden="true" padding>