fix(refresher): adds threshold

This commit is contained in:
Manu Mtz.-Almeida
2018-05-11 14:39:25 +02:00
parent b06c65fa40
commit 34ae9045b7
2 changed files with 13 additions and 19 deletions

View File

@ -26,7 +26,6 @@ export class Refresher {
private appliedStyles = false;
private didStart = false;
private gestureConfig: any;
private progress = 0;
private scrollEl: HTMLElement | null = null;
@ -94,22 +93,6 @@ export class Refresher {
*/
@Event() ionStart!: EventEmitter<void>;
componentWillLoad() {
this.gestureConfig = {
'canStart': this.canStart.bind(this),
'onStart': this.onStart.bind(this),
'onMove': this.onMove.bind(this),
'onEnd': this.onEnd.bind(this),
'gestureName': 'refresher',
'gesturePriority': 10,
'type': 'pan',
'passive': false,
'direction': 'y',
'threshold': 0,
'attachTo': this.el.closest('ion-content')
};
}
componentDidLoad() {
if (this.el.getAttribute('slot') !== 'fixed') {
console.error('Make sure you use: <ion-refresher slot="fixed">');
@ -241,6 +224,7 @@ export class Refresher {
}
// prevent native scroll events
console.log('preventDefault');
ev.preventDefault();
// the refresher is actively pulling at this point
@ -360,7 +344,17 @@ export class Refresher {
}
render() {
return <ion-gesture {...this.gestureConfig}
return <ion-gesture
canStart={this.canStart.bind(this)}
onStart={this.onStart.bind(this)}
onMove={this.onMove.bind(this)}
onEnd={this.onEnd.bind(this)}
gestureName="refresher"
gesturePriority={10}
passive={false}
direction="y"
threshold={5}
attachTo={this.el.closest('ion-content') as any}
disabled={this.disabled}>
<slot></slot>
</ion-gesture>;

View File

@ -54,7 +54,7 @@
function render() {
let html = '';
for(let item of items) {
html += `<ion-item>${item}</ion-item>`;
html += `<ion-item button>${item}</ion-item>`;
}
list.innerHTML = html;
}