javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(types): remove overlay attribute interfaces (#26181)

Browse Source 
BREAKING CHANGE:

`ActionSheetAttributes`, `AlertAttributes`, `AlertTextareaAttributes`, `AlertInputAttributes`, `LoadingAttributes`, `ModalAttributes`, `PickerAttributes`, `PopoverAttributes`, and `ToastAttributes` have been removed. Developers should use `{ [key: string]: any }` instead.
This commit is contained in:
Liam DeBeasi
2022-10-28 15:12:28 -05:00
committed by GitHub
parent 34ca337b8a
commit 322a1dbcd0
19 changed files with 40 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/components/loading/loading-interface.ts
View File

@ -13,13 +13,8 @@ export interface LoadingOptions {
mode?: Mode;
keyboardClose?: boolean;
id?: string;
htmlAttributes?: LoadingAttributes;
htmlAttributes?: { [key: string]: any };
enterAnimation?: AnimationBuilder;
leaveAnimation?: AnimationBuilder;
}
/**
* @deprecated - Use { [key: string]: any } directly instead.
*/
export type LoadingAttributes = { [key: string]: any };

3
core/src/components/loading/loading.tsx
View File

@ -6,7 +6,6 @@ import { getIonMode } from '../../global/ionic-global';
import type {
AnimationBuilder,
FrameworkDelegate,
LoadingAttributes,
OverlayEventDetail,
OverlayInterface,
SpinnerTypes,
@ -122,7 +121,7 @@ export class Loading implements ComponentInterface, OverlayInterface {
/**
* Additional attributes to pass to the loader.
*/
@Prop() htmlAttributes?: LoadingAttributes;
@Prop() htmlAttributes?: { [key: string]: any };
/**
* If `true`, the loading indicator will open. If `false`, the loading indicator will close.