javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(types): remove overlay attribute interfaces (#26181)

Browse Source 
BREAKING CHANGE:

`ActionSheetAttributes`, `AlertAttributes`, `AlertTextareaAttributes`, `AlertInputAttributes`, `LoadingAttributes`, `ModalAttributes`, `PickerAttributes`, `PopoverAttributes`, and `ToastAttributes` have been removed. Developers should use `{ [key: string]: any }` instead.
This commit is contained in:
Liam DeBeasi
2022-10-28 15:12:28 -05:00
committed by GitHub
parent 34ca337b8a
commit 322a1dbcd0
19 changed files with 40 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/components/action-sheet/action-sheet-interface.ts
View File

@ -11,17 +11,12 @@ export interface ActionSheetOptions {
mode?: Mode;
keyboardClose?: boolean;
id?: string;
htmlAttributes?: ActionSheetAttributes;
htmlAttributes?: { [key: string]: any };
enterAnimation?: AnimationBuilder;
leaveAnimation?: AnimationBuilder;
}
/**
* @deprecated - Use { [key: string]: any } directly instead.
*/
export type ActionSheetAttributes = { [key: string]: any };
export interface ActionSheetButton<T = any> {
text?: string;
role?: 'cancel' | 'destructive' | 'selected' | string;

3
core/src/components/action-sheet/action-sheet.tsx
View File

@ -3,7 +3,6 @@ import { Component, Element, Event, Host, Method, Prop, h, readTask } from '@ste
import { getIonMode } from '../../global/ionic-global';
import type {
ActionSheetAttributes,
ActionSheetButton,
AnimationBuilder,
CssClassMap,
@ -100,7 +99,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
/**
* Additional attributes to pass to the action sheet.
*/
@Prop() htmlAttributes?: ActionSheetAttributes;
@Prop() htmlAttributes?: { [key: string]: any };
/**
* Emitted after the alert has presented.