javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 22:17:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(virtual-scroll): fix tests

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-02-06 20:02:38 +01:00
parent fcbe1818fa
commit 2ebd460b84
3 changed files with 71 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/src/components/virtual-scroll/test/basic.html
View File

@ -24,7 +24,6 @@
<ion-content> <ion-content>
<p> <p>
<ion-button onclick="addItems()">Add Items</ion-button> <ion-button onclick="addItems()">Add Items</ion-button>
</p> </p>
<ion-virtual-scroll id="virtual"></ion-virtual-scroll> <ion-virtual-scroll id="virtual"></ion-virtual-scroll>
</ion-content> </ion-content>
@ -38,8 +37,8 @@
const virtual = document.getElementById('virtual'); const virtual = document.getElementById('virtual');
virtual.addItems() virtual.addItems()
} }
async function init() {
const virtual = await document.getElementById('virtual').componentOnReady(); const virtual = document.getElementById('virtual');
virtual.itemHeight = () => 45; virtual.itemHeight = () => 45;
virtual.headerFn = (item, index) => { virtual.headerFn = (item, index) => {
if (index % 20 === 0) { if (index % 20 === 0) {
@ -77,9 +76,6 @@
return renderHeader(el, cell.value); return renderHeader(el, cell.value);
}; };
virtual.items = Array.from({length: 1000}, (x, i) => i); virtual.items = Array.from({length: 1000}, (x, i) => i);
};
setTimeout(init, 200);
</script> </script>
</body> </body>
</html> </html>

9
packages/core/src/components/virtual-scroll/test/cards.html
View File

@ -27,12 +27,8 @@
</ion-app> </ion-app>
<script> <script>
const virtual = document.getElementById('virtual');
async function init() {
const virtual = await document.getElementById('virtual').componentOnReady();
virtual.approxItemHeight = 200; virtual.approxItemHeight = 200;
// virtual.itemHeight = (item) => 69 + 40 + 22 * Math.ceil(item.content.length/30);
virtual.headerFn = (item, index) => { virtual.headerFn = (item, index) => {
if (index % 20 === 0) { if (index % 20 === 0) {
return 'Header ' + index; return 'Header ' + index;
@ -40,7 +36,6 @@
return null; return null;
} }
function renderItem(el, item) { function renderItem(el, item) {
if (!el) { if (!el) {
el = document.createElement('ion-card'); el = document.createElement('ion-card');
@ -73,8 +68,6 @@
}); });
} }
virtual.items = items; virtual.items = items;
};
setTimeout(init, 200);
</script> </script>
</body> </body>

6
packages/core/src/components/virtual-scroll/virtual-scroll.scss
View File

@ -6,7 +6,7 @@ ion-virtual-scroll {
width: 100%; width: 100%;
// contain: strict; contain: content;
} }
.virtual-loading { .virtual-loading {
@ -18,6 +18,8 @@ ion-virtual-scroll {
position: absolute; position: absolute;
transition-duration: 0ms;
will-change: transform; will-change: transform;
// contain: strict; contain: content;
} }