fix(virtual-scroll): fix tests

This commit is contained in:
Manu Mtz.-Almeida
2018-02-06 20:02:38 +01:00
parent fcbe1818fa
commit 2ebd460b84
3 changed files with 71 additions and 80 deletions

View File

@ -24,7 +24,6 @@
<ion-content>
<p>
<ion-button onclick="addItems()">Add Items</ion-button>
</p>
<ion-virtual-scroll id="virtual"></ion-virtual-scroll>
</ion-content>
@ -38,48 +37,45 @@
const virtual = document.getElementById('virtual');
virtual.addItems()
}
async function init() {
const virtual = await document.getElementById('virtual').componentOnReady();
virtual.itemHeight = () => 45;
virtual.headerFn = (item, index) => {
if (index % 20 === 0) {
return 'Header ' + index;
}
return null;
}
function renderItem(el, item) {
if (!el) {
el = document.createElement('ion-item');
const text = document.createTextNode(item);
el['$content'] = text;
el.appendChild(text);
} else {
el['$content'].nodeValue = item;
}
return el;
const virtual = document.getElementById('virtual');
virtual.itemHeight = () => 45;
virtual.headerFn = (item, index) => {
if (index % 20 === 0) {
return 'Header ' + index;
}
return null;
}
function renderHeader(el, item) {
if (!el) {
el = document.createElement('ion-item-divider');
const text = document.createTextNode(item);
el['$content'] = text;
el.appendChild(text);
} else {
el['$content'].nodeValue = item;
}
return el;
function renderItem(el, item) {
if (!el) {
el = document.createElement('ion-item');
const text = document.createTextNode(item);
el['$content'] = text;
el.appendChild(text);
} else {
el['$content'].nodeValue = item;
}
return el;
}
virtual.itemRender = (el, cell) => {
if (cell.type === 0) return renderItem(el, cell.value);
return renderHeader(el, cell.value);
};
virtual.items = Array.from({length: 1000}, (x, i) => i);
function renderHeader(el, item) {
if (!el) {
el = document.createElement('ion-item-divider');
const text = document.createTextNode(item);
el['$content'] = text;
el.appendChild(text);
} else {
el['$content'].nodeValue = item;
}
return el;
}
virtual.itemRender = (el, cell) => {
if (cell.type === 0) return renderItem(el, cell.value);
return renderHeader(el, cell.value);
};
setTimeout(init, 200);
virtual.items = Array.from({length: 1000}, (x, i) => i);
</script>
</body>
</html>

View File

@ -27,54 +27,47 @@
</ion-app>
<script>
async function init() {
const virtual = await document.getElementById('virtual').componentOnReady();
virtual.approxItemHeight = 200;
// virtual.itemHeight = (item) => 69 + 40 + 22 * Math.ceil(item.content.length/30);
virtual.headerFn = (item, index) => {
if (index % 20 === 0) {
return 'Header ' + index;
}
return null;
const virtual = document.getElementById('virtual');
virtual.approxItemHeight = 200;
virtual.headerFn = (item, index) => {
if (index % 20 === 0) {
return 'Header ' + index;
}
return null;
}
function renderItem(el, item) {
if (!el) {
el = document.createElement('ion-card');
}
el.innerHTML = `
<ion-card-header>
<ion-card-title>Card Header</ion-card-title>
</ion-card-header>
<ion-card-content>${item.content}</ion-card-content>`;
return el;
function renderItem(el, item) {
if (!el) {
el = document.createElement('ion-card');
}
el.innerHTML = `
<ion-card-header>
<ion-card-title>Card Header</ion-card-title>
</ion-card-header>
<ion-card-content>${item.content}</ion-card-content>`;
return el;
}
function renderHeader(el, item) {
if (!el) {
el = document.createElement('ion-item-divider');
}
el.textContent = item;
return el;
function renderHeader(el, item) {
if (!el) {
el = document.createElement('ion-item-divider');
}
el.textContent = item;
return el;
}
virtual.itemRender = (el, cell) => {
if (cell.type === 0) return renderItem(el, cell.value);
return renderHeader(el, cell.value);
};
const lorem = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.';
const items = [];
for (var i = 0; i < 1000; i++) {
items.push({
content: lorem.substring(0, (Math.random() * (lorem.length - 100)) + 100)
});
}
virtual.items = items;
virtual.itemRender = (el, cell) => {
if (cell.type === 0) return renderItem(el, cell.value);
return renderHeader(el, cell.value);
};
setTimeout(init, 200);
const lorem = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.';
const items = [];
for (var i = 0; i < 1000; i++) {
items.push({
content: lorem.substring(0, (Math.random() * (lorem.length - 100)) + 100)
});
}
virtual.items = items;
</script>
</body>

View File

@ -6,7 +6,7 @@ ion-virtual-scroll {
width: 100%;
// contain: strict;
contain: content;
}
.virtual-loading {
@ -18,6 +18,8 @@ ion-virtual-scroll {
position: absolute;
transition-duration: 0ms;
will-change: transform;
// contain: strict;
contain: content;
}