javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not emit ionChange if value did not change

Browse Source
This commit is contained in:
Liam DeBeasi
2023-12-01 15:29:40 -05:00
parent b1fc67227c
commit 2c773ed0e6
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
core/src/components/picker-column/picker-column.tsx
View File

@@ -134,22 +134,18 @@ export class PickerColumn implements ComponentInterface {
componentDidRender() {
const { el, activeItem, isColumnVisible, value } = this;
if (isColumnVisible) {
if (activeItem) {
this.scrollActiveItemIntoView();
} else {
const firstOption = el.querySelector('ion-picker-column-option');
if (isColumnVisible && !activeItem) {
const firstOption = el.querySelector('ion-picker-column-option');
/**
* If the picker column does not have an active item and the current value
* does not match the first item in the picker column, that means
* the value is out of bounds. In this case, we assign the value to the
* first item to match the scroll position of the column.
*
*/
if (firstOption !== null && firstOption.value !== value) {
this.setValue(firstOption.value);
}
/**
* If the picker column does not have an active item and the current value
* does not match the first item in the picker column, that means
* the value is out of bounds. In this case, we assign the value to the
* first item to match the scroll position of the column.
*
*/
if (firstOption !== null && firstOption.value !== value) {
this.setValue(firstOption.value);
}
}
}
@@ -173,6 +169,8 @@ export class PickerColumn implements ComponentInterface {
*/
@Method()
async setValue(value?: string | number) {
if (this.value === value) { return; }
this.value = value;
this.ionChange.emit(value);
}