javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 03:32:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(menu): crash when menu if forcedClosed

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-09-26 00:35:48 +02:00
parent b71b36c7e4
commit 22e15b4c5b
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/components/menu/menu.tsx
View File

@ -392,7 +392,8 @@ export class Menu implements ComponentInterface, MenuI {
this.lastOnEnd = detail.timeStamp; this.lastOnEnd = detail.timeStamp;
this.animation this.animation
.onFinish(() => this.afterAnimation(shouldOpen), { .onFinish(() => this.afterAnimation(shouldOpen), {
clearExistingCallbacks: true clearExistingCallbacks: true,
oneTimeCallback: true
}) })
.progressEnd(shouldComplete, stepValue, realDur); .progressEnd(shouldComplete, stepValue, realDur);
} }

3
core/src/components/menu/test/basic/index.html
View File

@ -31,7 +31,7 @@
<ion-content> <ion-content>
<ion-list> <ion-list>
<ion-item>Open end Menu</ion-item> <ion-item button onclick="openEnd()">Open end Menu</ion-item>
<ion-item>Close Menu</ion-item> <ion-item>Close Menu</ion-item>
<ion-item>Close Menu</ion-item> <ion-item>Close Menu</ion-item>
<ion-item>Close Menu</ion-item> <ion-item>Close Menu</ion-item>
@ -108,6 +108,7 @@
menu.open('start'); menu.open('start');
} }
function openEnd() { function openEnd() {
debugger;
console.log('Open end menu'); console.log('Open end menu');
menu.open('end'); menu.open('end');
} }