From 22e15b4c5bede0f81ce18e66680445dd309178d2 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Wed, 26 Sep 2018 00:35:48 +0200 Subject: [PATCH] fix(menu): crash when menu if forcedClosed --- core/src/components/menu/menu.tsx | 3 ++- core/src/components/menu/test/basic/index.html | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/components/menu/menu.tsx b/core/src/components/menu/menu.tsx index eec0001800..15bb7cf2f7 100644 --- a/core/src/components/menu/menu.tsx +++ b/core/src/components/menu/menu.tsx @@ -392,7 +392,8 @@ export class Menu implements ComponentInterface, MenuI { this.lastOnEnd = detail.timeStamp; this.animation .onFinish(() => this.afterAnimation(shouldOpen), { - clearExistingCallbacks: true + clearExistingCallbacks: true, + oneTimeCallback: true }) .progressEnd(shouldComplete, stepValue, realDur); } diff --git a/core/src/components/menu/test/basic/index.html b/core/src/components/menu/test/basic/index.html index 80e12a2535..b40c063f6a 100644 --- a/core/src/components/menu/test/basic/index.html +++ b/core/src/components/menu/test/basic/index.html @@ -31,7 +31,7 @@ - Open end Menu + Open end Menu Close Menu Close Menu Close Menu @@ -108,6 +108,7 @@ menu.open('start'); } function openEnd() { + debugger; console.log('Open end menu'); menu.open('end'); }