javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-12-19 05:19:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react-router): cleanup sibling views on push navigation to container routes

Browse Source
This commit is contained in:
ShaneK
2025-12-18 12:22:58 -08:00
parent 8052ea13ef
commit 1e2bebb10e
1 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/react-router/src/ReactRouter/StackManager.tsx
View File

@@ -442,19 +442,38 @@ export class StackManager extends React.PureComponent<StackManagerProps> {
}
/**
* Cleans up orphaned sibling views after replace actions (redirects).
* Cleans up orphaned sibling views after replace actions or push-to-container navigations.
*/
private cleanupOrphanedSiblingViews(
routeInfo: RouteInfo,
enteringViewItem: ViewItem,
leavingViewItem: ViewItem | undefined
): void {
if (routeInfo.routeAction !== 'replace') {
const enteringRoutePath = enteringViewItem.reactElement?.props?.path as string | undefined;
if (!enteringRoutePath) {
return;
}
const enteringRoutePath = enteringViewItem.reactElement?.props?.path as string | undefined;
if (!enteringRoutePath) {
const leavingRoutePath = leavingViewItem?.reactElement?.props?.path as string | undefined;
const isContainerRoute = (path: string | undefined) => path?.endsWith('/*');
const isReplaceAction = routeInfo.routeAction === 'replace';
const isPushToContainer =
routeInfo.routeAction === 'push' && routeInfo.routeDirection === 'none' && isContainerRoute(enteringRoutePath);
if (!isReplaceAction && !isPushToContainer) {
return;
}
// Skip cleanup for tab switches
const isSameView = enteringViewItem === leavingViewItem;
const isSameContainerRoute = isContainerRoute(enteringRoutePath) && leavingRoutePath === enteringRoutePath;
const isNavigatingWithinContainer =
isPushToContainer &&
!leavingViewItem &&
routeInfo.prevRouteLastPathname?.startsWith(enteringRoutePath.replace(/\/\*$/, ''));
if (isSameView || isSameContainerRoute || isNavigatingWithinContainer) {
return;
}