javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(animation): only update progressStep once per 16ms

Browse Source
This commit is contained in:
Adam Bradley
2016-02-18 09:48:56 -06:00
parent 22c32f3ab5
commit 098371a709
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
ionic/animations/animation.ts
View File

@@ -26,6 +26,7 @@ export class Animation {
private _rv: boolean;
private _unregTrans: Function;
private _tmr: any;
private _lastUpd: number = 0;
public isPlaying: boolean;
public hasTween: boolean;
@@ -174,7 +175,7 @@ export class Animation {
};
if (typeof val === 'string' && val.indexOf(' ') < 0) {
let r = val.match(/(^-?\d*\.?\d*)(.*)/);
let r = val.match(cssValueRegex);
let num = parseFloat(r[1]);
if (!isNaN(num)) {
@@ -600,17 +601,26 @@ export class Animation {
}
progressStep(stepValue: number) {
stepValue = Math.min(1, Math.max(0, stepValue));
let now = Date.now();
for (var i = 0; i < this._c.length; i++) {
this._c[i].progressStep(stepValue);
// only update if the last update was more than 16ms ago
if (now - 16 > this._lastUpd) {
this._lastUpd = now;
stepValue = Math.min(1, Math.max(0, stepValue));
for (var i = 0; i < this._c.length; i++) {
this._c[i].progressStep(stepValue);
}
if (this._rv) {
// if the animation is going in reverse then
// flip the step value: 0 becomes 1, 1 becomes 0
stepValue = ((stepValue * -1) + 1);
}
this._progress(stepValue);
}
if (this._rv) {
stepValue = ((stepValue * -1) + 1);
}
this._progress(stepValue);
}
progressEnd(shouldComplete: boolean, currentStepValue: number) {
@@ -765,4 +775,6 @@ const TRANSFORMS = {
'skewX':1, 'skewY':1, 'perspective':1
};
const cssValueRegex = /(^-?\d*\.?\d*)(.*)/;
let AnimationRegistry = {};