javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sideMenuController): deregister backbutton on $destroy

Browse Source
This commit is contained in:
Andy Joslin
2014-05-06 10:46:58 -06:00
parent 101035593f
commit 053bc04fd4
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
js/angular/controller/sideMenuController.js vendored
View File

@@ -50,5 +50,8 @@ function($scope, $attrs, $ionicSideMenuDelegate, $ionicPlatform) {
var deregisterInstance = $ionicSideMenuDelegate._registerInstance(
this, $attrs.delegateHandle
);
$scope.$on('$destroy', deregisterInstance);
$scope.$on('$destroy', function() {
deregisterInstance();
deregisterBackButtonAction();
});
}]);

16
test/unit/angular/controller/sideMenuController.unit.js
View File

@@ -34,4 +34,20 @@ describe('$ionicSideMenus controller', function() {
ctrl.$scope.$apply();
expect(deregSpy).toHaveBeenCalled();
}));
it('should deregister back button action on $destroy', inject(function($ionicPlatform) {
var openAmount = 0;
var deregSpy = jasmine.createSpy('deregister');
spyOn($ionicPlatform, 'registerBackButtonAction').andReturn(deregSpy);
var ctrl = setup();
spyOn(ctrl, 'getOpenAmount').andCallFake(function() { return openAmount; });
expect($ionicPlatform.registerBackButtonAction).not.toHaveBeenCalled();
openAmount = 1;
ctrl.$scope.$apply();
expect(deregSpy).not.toHaveBeenCalled();
ctrl.$scope.$destroy();
expect(deregSpy).toHaveBeenCalled();
}));
});