javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 02:31:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(picker): fix iOS picker options that shouldn't be showing (#16055)

Browse Source
This commit is contained in:
Adam Bradley
2018-10-23 23:13:45 -05:00
committed by GitHub
parent b2021fd9c4
commit 02ef52b85c
3 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/src/components/datetime/test/standalone/e2e.ts
View File

@ -13,6 +13,7 @@ it('datetime: standalone', async () => {
const picker = await page.find('ion-picker'); const picker = await page.find('ion-picker');
await picker.waitForVisible(); await picker.waitForVisible();
await page.waitFor(250);
compare = await page.compareScreenshot('should open basic picker'); compare = await page.compareScreenshot('should open basic picker');
expect(compare).toMatchScreenshot(); expect(compare).toMatchScreenshot();

3
core/src/components/picker-column/picker-column.tsx
View File

@ -116,7 +116,10 @@ export class PickerColumnCmp implements ComponentInterface {
translateY = 0; translateY = 0;
translateZ = 90; translateZ = 90;
transform = `rotateX(${rotateX}deg) `; transform = `rotateX(${rotateX}deg) `;
} else {
translateY = -9999;
} }
} else { } else {
translateZ = 0; translateZ = 0;
translateY = optOffset; translateY = optOffset;

2
core/src/components/select/test/basic/e2e.ts
View File

@ -13,6 +13,7 @@ it('select: basic', async () => {
const alert = await page.find('ion-alert'); const alert = await page.find('ion-alert');
await alert.waitForVisible(); await alert.waitForVisible();
await page.waitFor(100);
compare = await page.compareScreenshot('should open gender single select'); compare = await page.compareScreenshot('should open gender single select');
expect(compare).toMatchScreenshot(); expect(compare).toMatchScreenshot();
@ -21,6 +22,7 @@ it('select: basic', async () => {
select = await page.find('#customSelect'); select = await page.find('#customSelect');
await select.click(); await select.click();
await page.waitFor(100);
const actionSheet = await page.find('ion-action-sheet'); const actionSheet = await page.find('ion-action-sheet');
await actionSheet.waitForVisible(); await actionSheet.waitForVisible();