From 02ef52b85c17f72c6abc9912a4ae709b608147e7 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Tue, 23 Oct 2018 23:13:45 -0500 Subject: [PATCH] fix(picker): fix iOS picker options that shouldn't be showing (#16055) --- core/src/components/datetime/test/standalone/e2e.ts | 1 + core/src/components/picker-column/picker-column.tsx | 3 +++ core/src/components/select/test/basic/e2e.ts | 2 ++ 3 files changed, 6 insertions(+) diff --git a/core/src/components/datetime/test/standalone/e2e.ts b/core/src/components/datetime/test/standalone/e2e.ts index 37a9ebe607..63c9d9617b 100644 --- a/core/src/components/datetime/test/standalone/e2e.ts +++ b/core/src/components/datetime/test/standalone/e2e.ts @@ -13,6 +13,7 @@ it('datetime: standalone', async () => { const picker = await page.find('ion-picker'); await picker.waitForVisible(); + await page.waitFor(250); compare = await page.compareScreenshot('should open basic picker'); expect(compare).toMatchScreenshot(); diff --git a/core/src/components/picker-column/picker-column.tsx b/core/src/components/picker-column/picker-column.tsx index 0fa7729938..40aa7e4e5b 100644 --- a/core/src/components/picker-column/picker-column.tsx +++ b/core/src/components/picker-column/picker-column.tsx @@ -116,7 +116,10 @@ export class PickerColumnCmp implements ComponentInterface { translateY = 0; translateZ = 90; transform = `rotateX(${rotateX}deg) `; + } else { + translateY = -9999; } + } else { translateZ = 0; translateY = optOffset; diff --git a/core/src/components/select/test/basic/e2e.ts b/core/src/components/select/test/basic/e2e.ts index 1cb128b88b..5073bdcd36 100644 --- a/core/src/components/select/test/basic/e2e.ts +++ b/core/src/components/select/test/basic/e2e.ts @@ -13,6 +13,7 @@ it('select: basic', async () => { const alert = await page.find('ion-alert'); await alert.waitForVisible(); + await page.waitFor(100); compare = await page.compareScreenshot('should open gender single select'); expect(compare).toMatchScreenshot(); @@ -21,6 +22,7 @@ it('select: basic', async () => { select = await page.find('#customSelect'); await select.click(); + await page.waitFor(100); const actionSheet = await page.find('ion-action-sheet'); await actionSheet.waitForVisible();