javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(reorder-group): dragging reorder item to bottom no longer gives out of bounds index (#23797)

Browse Source 
resolves #23796
This commit is contained in:
Toby Smith
2021-08-23 14:38:27 +01:00
committed by GitHub
parent 864212b0f2
commit 02409f2abf
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/components/reorder-group/reorder-group.tsx
View File

@@ -245,17 +245,16 @@ export class ReorderGroup implements ComponentInterface {
private itemIndexForTop(deltaY: number): number {
const heights = this.cachedHeights;
let i = 0;
// TODO: since heights is a sorted array of integers, we can do
// speed up the search using binary search. Remember that linear-search is still
// faster than binary-search for small arrays (<64) due CPU branch misprediction.
for (i = 0; i < heights.length; i++) {
for (let i = 0; i < heights.length; i++) {
if (heights[i] > deltaY) {
break;
return i;
}
}
return i;
return heights.length - 1;
}
/********* DOM WRITE ********* */