Commit Graph

5061 Commits

Author SHA1 Message Date
Svetoslav
fce9ac8d27 Merge branch 'master' into svetoslavtsenov/update-modal-navigation-tests 2019-01-09 19:57:00 +02:00
Vasil Trifonov
28db2afbd4 feat: OnDiscardedError typings and event (#6777)
* feat: OnDiscardedError typings and event

* remove ios and android from DiscardedErrorEventData
2019-01-09 18:24:25 +02:00
SvetoslavTsenov
1255a3c9ae tests: update driver default wait time 2019-01-09 16:26:15 +02:00
Manol Donev
4cda0e7345 refactor: enable e2e tests with mixed animation nav (#6775) 2019-01-09 16:16:08 +02:00
Vasil Chimev
1f1d722008 fix(Android): a crash on application restart after livesync changes (#6756)
```
An uncaught Exception occurred on "main" thread.
com.tns.NativeScriptException:
Calling js method run failed

TypeError: Cannot read property 'getRootView' of undefined
File: file:///data/data/org.nativescript.preview/files/app/tns_modules/tns-core-modules/ui/frame/frame.js, line: 56, column:29
```
2019-01-08 21:03:28 +02:00
Nikolay Tsonev
3a8c3fca75 feat(modals): option to make dialogs cancelable in Android (#6765) 2019-01-08 16:56:30 +02:00
Manol Donev
a6d561e549 refactor: update e2e tests for CI (#6722) 2019-01-08 15:23:35 +02:00
Manol Donev
46c9de020e fix(android): raise resume event on activity.onPostResume() (#6766) 2019-01-08 15:20:11 +02:00
Svetoslav
42c25370ee chore: merge release in master (#6731)
* Fix some lint errors

* release: cut the 5.1.1 release

* chore: bump widgets version to 5.1.2
2019-01-08 13:55:50 +02:00
Alexander Djenkov
2085d1e4ac fix(list-view-android): app crashes on ListView item template change (#6634)
* fix(list-view): app crashes on first ListView item template change

* tests: add tests for changing ListView item template with expression
2019-01-08 13:48:47 +02:00
Emil Tabakov
35ebe8b91d chore: update LICENSE for tns-core-modules (#6761) 2019-01-07 15:17:15 +02:00
Emil Tabakov
37f5359fc5 chore: update community files (#6763) 2019-01-07 15:12:05 +02:00
Alexander Djenkov
984f162c1c fix(tab-view): remove onBackPressed override (#6755) 2019-01-04 16:57:26 +02:00
Manol Donev
1ae0cfd4b3 refactor: cleanup unused elements (#6732) 2019-01-02 11:17:55 +02:00
Nikolay Tsonev
6cdb01d432 set the correct application theme while creating the dialog fragment (#6691)
* set the correct application theme while creating the dialog fragment

* useing the new approche fusing the new approach for setting the theme only when the modal view is fullscreen(it will break the style when using non-fullscreen modal)

* note - get theme change

* set the correct application theme while creating the dialog fragment

* useing the new approche fusing the new approach for setting the theme only when the modal view is fullscreen(it will break the style when using non-fullscreen modal)

* note - get theme change
2018-12-31 14:20:52 +02:00
Vasil Chimev
2b7e7d89e0 fix-next: undefined root view when reapplying styles (#6729)
* fix: undefined root view when reapplying styles

Error:
```
JS ERROR TypeError: undefined is not an object (evaluating
'application_1.getRootView()._onCssStateChange')
```

Steps:
- `tns run <platform> --hmr`
- make a change in application styles
- restart the application
2018-12-27 16:44:24 +02:00
Alexander Vakrilov
8a32102fa1 fix(modal): Fix crash if modal is destroyed before dismissed in Android (#6723) 2018-12-20 17:24:13 +02:00
Svetoslav
36f289b9a5 Merge pull request #6721 from NativeScript/darind/lint-fixes
Fix some lint errors
2018-12-18 14:33:05 +02:00
Darin Dimitrov
db4f9f5ddb Fix some lint errors 2018-12-18 14:23:27 +02:00
Manol Donev
961b03ecef chore: temporarily disable e2e tests with mixed animation nav (#6720) 2018-12-18 10:25:32 +02:00
Manol Donev
4dc35a5e6f fix(android): failure saving state in mixed parent/nested frame nav (#6719) 2018-12-18 10:23:02 +02:00
Martin Bektchiev
89870f7c91 chore(docs): Upgrade typedoc to version 0.13.0 (#6717)
Building with the current 0.5.10 now fails because it depends on typescript
before 2.4. This causes the following errors:
```
NativeScript@ typedoc /root/NativeScript
> typedoc --tsconfig tsconfig.typedoc.json --out bin/dist/apiref --includeDeclarations --name NativeScript --theme ./node_modules/nativescript-typedoc-theme --excludeExternals --externalPattern "**/+(tns-core-modules|module).d.ts"

Loaded plugin typedoc-plugin-external-module-name

Using TypeScript 2.2.2 from /root/NativeScript/node_modules/typedoc/node_modules/typescript/lib
Error: /root/NativeScript/tns-core-modules/module.d.ts(67)
In ambient enum declarations member initializer must be constant expression.
Error: /root/NativeScript/tns-core-modules/module.d.ts(68)
In ambient enum declarations member initializer must be constant expression.
Error: /root/NativeScript/tns-core-modules/module.d.ts(69)
In ambient enum declarations member initializer must be constant expression.
```

This fix is required to support typeodoc@0.8.0 and above:
01f94b4ae2
2018-12-17 17:05:09 +02:00
Manol Donev
c034d6ead6 fix(android): animator restore logic on simulated nav (#6710) 2018-12-17 15:27:52 +02:00
Nathan Walker
3481e6f33f feat(image-cache): expose onError callback (#6458)
* feat(Cache): better error handling

* refactor(image-cache): add `error` parameter to `_onDownloadError`

Add DownloadError interface.

* refactor(image-cache): updates for iOS

Use arrow functions.
Remove an unnecessary `trace.write().

* refactor(image-cache): updates for Android

Update Android `constructor()`.
Move `key` and `image` check to `set()`.
Update `trace.write`.

* fix(image-cache): onError handling
2018-12-17 11:33:12 +02:00
Svetoslav
134b033b77 Merge pull request #6707 from NativeScript/release 2018-12-14 16:40:11 +02:00
Svetoslav
07c4e5fa96 Merge pull request #6665 from NativeScript/vchimev/app-css-hmr
feat(HMR): apply changes in application styles at runtime
2018-12-14 16:39:42 +02:00
SvetoslavTsenov
ea44416734 Merge remote-tracking branch 'origin/master' into release 2018-12-14 14:53:53 +02:00
Vasil Chimev
c404a38038 refactor: tests to parce templates 2018-12-14 14:35:47 +02:00
Vasil Chimev
b9d7d6bb62 test(HMR): apply changes in application styles at runtime 2018-12-14 14:35:46 +02:00
Vasil Chimev
4c15f71789 fix: iOS tests 2018-12-14 14:34:50 +02:00
Vasil Chimev
790bcfb470 refactor(HMR): apply changes in application styles at runtime 2018-12-14 14:34:50 +02:00
Vasil Chimev
42a1491e6e feat(HMR): apply changes in application styles at runtime
Expose `HmrContext` interface.
Apply changes in `app.css` instantly.
Avoid navigation on livesync when changes in `app.css` have been made.
Apply changes in `app.css` on back navigation.
2018-12-14 14:34:47 +02:00
Manol Donev
60957799ad chore: restore tabroot/resetrootview tests (#6705) 2018-12-14 14:22:07 +02:00
Nathanael Anderson
19895945c2 fix(ios delegate) Eliminate crash on selector looking for "Window" (#6428)
* Add a "window" value so that NS doesn't crash on selectors looking for the delegate.window...

* chore: tslint

* chore: comments to referenced issues added
2018-12-14 13:31:26 +02:00
Martin Bektchiev
1c0218ea15 feat(tns-platform-declarations): Generate iOS typings from iOS 12.1 SDK (#6693)
* feat(tns-platform-declarations): Generate iOS typings from iOS 12.1 SDK

* Instructions for generating iOS typescript definitions
* Refactor `typings-gen.sh` to use {N} CLI and generate fuller
metadata for the system libraries
* Automatically generate `ios.d.ts` wrapper
* Add interop pointers and references as alternatives
to `string` for `char*` args
(implemented in https://github.com/NativeScript/ios-runtime/pull/1022)

BREAKING CHANGE: Several enum values have changed because
    they have been wrongly generated.

    To migrate your app or plugin code use the new names of the
    following:
    *  enum NSUnderlineStyle:
        - `StyleNone` -> `None`
        - `StyleSingle` -> `Single`
        - `StyleThick` -> `Thick`
        - `StyleDouble` -> `Double`
     * enum AVAudioSessionErrorCode:
        - `CodeNone` -> `None`
        - `CodeMediaServicesFailed` -> `MediaServicesFailed`
        - `CodeIsBusy` -> `IsBusy`
        - `CodeIncompatibleCategory` -> `IncompatibleCategory`
        - `CodeCannotInterruptOthers` -> `CannotInterruptOthers`
        - `CodeMissingEntitlement` -> `MissingEntitlement`
        - `CodeSiriIsRecording` -> `SiriIsRecording`
        - `CodeCannotStartPlaying` -> `CannotStartPlaying`
        - `CodeCannotStartRecording` -> `CannotStartRecording`
        - `CodeBadParam` -> `BadParam`
        - `CodeResourceNotAvailable` -> `ResourceNotAvailable`
        - `CodeUnspecified` -> `Unspecified`

* fix(ui/text-base): Update NSUnderlineStyle.StyleSingle constant

After the typings regeneration its and several others' names have
changed to the expected `NSUnderlineStyle.Single`.

* fix(tns-platform-declarations): Restore deprecated enum values

In order to not introduce a breaking change in a patch version, we
are keeping `Style...` and `Code...` values that have been wrongly
generated till now. In the next major/minor release of the package
when the typings are regenerated we can safely remove them.

Revert to using the deprecated one's in `text-base.ios.ts` so that
the introduction of this breaking change doesn't slip in undetected.

* fix(application.ios): Directly call presetnNativeScriptApp

We've been using `performSelectorWithObject` but it's
declaration has been manually added. Moreover it's more
convenient to directly call the method.
2018-12-13 17:04:13 +02:00
Nicu
540b2b4f82 feat(view): added iOS parameter for modal presentation style (#6409)
* feat(view): added iOS parameter for modal presentation style

* Now passing options to showModal in one argument

* refactor: Move context and close in modal options

* chore: Comments added for UIModalPresentationStyle.Popover case

* refactor: Use modalOptions in e2e demo

* chore: fix pbroken test
2018-12-13 17:03:25 +02:00
Manol Donev
44dba1a0b7 chore: temporarily disable failing tests (#6703) 2018-12-13 16:27:14 +02:00
Manol Donev
c084660d0b fix(android): nested fragment disappears on parent fragment removal (#6677) 2018-12-12 14:16:10 +02:00
Svetoslav
43dddbbbc3 Merge pull request #6683 from NativeScript/svetoslavtsenov/update-contrinuting
svetoslavtsenov/update contrinuting
2018-12-07 16:55:39 +02:00
SvetoslavTsenov
05c842cd67 chore: typo 2018-12-07 16:04:56 +02:00
SvetoslavTsenov
4feb453b56 chore: update 2018-12-07 15:54:47 +02:00
SvetoslavTsenov
5ca6e99602 docs: update contributings doc 2018-12-07 14:29:22 +02:00
Svetoslav
7eaba62951 Merge pull request #6681 from NativeScript/svetoslavtsenov/bump-versions
chore: bump versions
2018-12-07 14:05:14 +02:00
SvetoslavTsenov
7c92416858 chore: bump versions 2018-12-07 11:03:14 +02:00
Svetoslav
9bf91773d7 Merge pull request #6680 from NativeScript/merge-release-in-master
Merge release in master
2018-12-07 11:02:03 +02:00
Svetoslav
562628f29c Merge pull request #6669 from NativeScript/release-5.1.0
Release 5.1.0
2018-12-06 11:22:43 +02:00
SvetoslavTsenov
259aaa49e1 chore: bump widgets version to 5.1.1 2018-12-05 20:38:32 +02:00
SvetoslavTsenov
ce766526b3 release: cut the 5.1.0 release 5.1.0 2018-12-05 20:28:12 +02:00
Martin Yankov
63be78a69c fix(listview): incorrect layout when scroll (#6656) 2018-12-05 16:28:37 +02:00
Alexander Vakrilov
30df4d9c4a fix(modals): regression with modals in angular (#6655) 2018-12-04 16:39:07 +02:00