4617 Commits

Author SHA1 Message Date
ec2ce7fe45 Profile iOS keypoints in the UINavigationViewController (#5108) 2017-12-04 17:43:48 +02:00
13e8bfb9d3 docs: Change up-for-grabs filter with help wanted (#5078)
Since we do not use `up-for-grabs` label anymore, the starting point for contributions is changed to filter by `help wanted` label.
2017-12-04 17:31:05 +02:00
43121cc815 chore(testRunner): update filnal message (#5119) 2017-12-01 17:47:38 +02:00
db41bec6fe refactor: reset css property value when ''" (empty string) is set (#5085) 2017-11-27 09:12:26 -05:00
255fedac83 Add a globals.registerWebpackModules that can register dynamic require webpack context (#5087) 2017-11-22 13:02:42 +02:00
71c50b2cb1 Typo (#5075) 2017-11-17 08:22:05 +02:00
fc9a0b7ad8 Introduce background shorthand property (#5053)
* Introduce background shorthand style property

* Add text property in parser for BackgroundPosition value

reason: prevent parsing of background position (pass it as sample string)

* Introduce background-shorthand test page

* Modify parser unit tests to respect the new BackgroundPosition 'text' property
2017-11-15 14:07:40 +02:00
ac3c895c89 Fix crash on iOS (#5071)
* Fix crash on iOS where JS object that extend NSObject was not hold into memory.

* TS fix
2017-11-14 13:36:23 +02:00
725475f860 Click next moves the focus to next focusable textfield (#5047)
* Click next moves the focus to next focusable textfield

Fixes https://github.com/NativeScript/NativeScript/issues/5033
When clicking next arrow on the virtual keyboard we were returning true which means we handled the event so the OS doesn't move the focus to the next item. This PR delete the `return true` when the action is `IME_ACTION_NEXT` so that next focusable item is automatically focued

* Fix IME_ACTION_PREVIOUS to raise returnPress event.
Added unit-test that IME_ACTION_PREVIOUS to raise returnPress event.
Refactored text-field-tests
2017-11-10 16:34:47 +02:00
43fbabb5e9 Fixed most module cyclic references. There is one left for ios and android: (#4978)
- http -> http-request -> image-source
that can't be fixed easily and will be removed once we delete image-source module because it is obsolete anyway.
There is one more for android:
- frame -> fragment that could be removed if we use global object.
Updated madge bersion
2017-11-10 15:47:02 +02:00
729b068e7b Fix android search-bar bug (#5046)
* Fix android search-bar bug

Searching twice for the same item in the search bar leads to a bug where `submit` event won't be raised.
This PR fixes https://github.com/NativeScript/NativeScript/issues/5039

* test: include new test page
2017-11-10 15:46:23 +02:00
011be368b1 Add a simple polyfil for System.import so we can use some Angular services out-of-the-box (#5042) 2017-11-07 14:59:36 +02:00
65a50bbf82 fixed removeEventListener super call (#4994) 2017-11-03 12:57:11 +02:00
6e9a99a962 chore: update repo to be compiled with TS ^2.6.1 (#5020) 2017-11-01 14:18:52 +02:00
f1c33d2420 Add function for profile loggin in release (#5018) 2017-11-01 13:24:57 +02:00
3e6f465cc8 fix: TextField not secure when keyboardType="number" (#5012) 2017-10-31 18:29:39 +02:00
32b9ec2159 refactor: set selectedIndex = 3 of list-picker (#5008)
* refactor: set selectedIndex = 3 of list-picker

* refactor: list-picker.ts

* refactor: list-picker.xml

* fix: remove ios import
2017-10-31 14:15:11 +02:00
b192abf4f2 Note about silent install mode in setup-scripts 2017-10-26 17:31:43 +03:00
d68ff42cc1 chore: bump version to 3.4.0 2017-10-24 15:39:06 +03:00
bb3a28453c docs: add changelog for 3.3.0 (#4979)
* chore: Changelog update for 3.3.0

* docs: minor tweaks on the changelog for 3.3.0
2017-10-24 15:19:35 +03:00
0fe1806aaf fix: Require core modules used for inspector lazily (#4977) 2017-10-24 11:53:51 +03:00
f7a3a36b9c Housekeeping node tests, renamed to unit-tests (#4936)
Add parsers for the background css shorthand property, make ViewBase unit testable in node environment

Add background parser and linear-gradient parser

Use sticky regexes

Simplify some types, introduce generic Parsed<T> instead of & TokenRange

Apply each parser to return a { start, end, value } object

Move the css selector parser to the css/parser and unify types

Add the first steps toward building homegrown css parser

Add somewhat standards compliant tokenizer, add baseline, rework and shady css parsers

Enable all tests again, skip flaky perf test

Improve css parser tokenizer by converting some char token types to simple string

Implement 'parse a stylesheet'

Add gonzales css-parser

Add parseLib and css-tree perf

Add a thin parser layer that will convert CSS3 tokens to values, for now output is compatible with rework

Make root tsc green

Return the requires of tns-core-modules to use relative paths for webpack to work

Implement support for '@import 'url-string';

Fix function parser, function-token is no-longer neglected

Make the style-scope be able to load from "css" and "css-ast" modules

Add a loadAppCss event so theme can be added to snapshot separately from loaded
2017-10-20 10:42:07 +03:00
2eba7c66e4 Fix for iOS 11 ListView top offset (#4919)
* Changed the default value of the new iOS11 'contentInsetAdjustmentBehavior' property #4916

* Fixed missing ts definitions and added TODOs
2017-10-20 08:38:07 +03:00
7c68953009 Fix clear history transition (#4951)
* fix: Navigation test app added

* Removed native popToBackstack call.
Implemented custom fragment save/restore state.
When navigating back we reverse manually transitions/animations because we no longer add them to navite backstack.
Fragment instance stored on entry.
Animation and Transition listeners now holds reference to entry instead of fragment for easier update of fragment.
Animation and Transition listeners removed when entry removed from backstack.
Animation and Transition removed from fragment when fragment activity is destroyed.

* Revert package.json start up entry
Fixed bug where goBack took the last element in backstack while navigationQueue is not empty.
Fixed bug where goBack to specific entry in the backstack was removing that entry...
Removed duplicated method
Refactored method name
Fixed TS
2017-10-20 08:37:36 +03:00
2e09d3714a FIX: Now checking that webView.request.URL is not null before accessing properties on it. (#4830)
- The symptom is the app would crash when web view tries to load
certain (valid) requests.
2017-10-20 08:36:06 +03:00
d3a6a3f782 Line-height property breaks text alignment (iOS) (#4909) 2017-10-20 08:35:11 +03:00
1b9610b4dd The original issue described here: https://github.com/NativeScript/NativeScript/issues/4804 is fixed in 3.2 but there is another bug which doesn't render borderRadius on Image element. (#4963) 2017-10-20 08:33:08 +03:00
188c1f2568 Hanlde hint color reset properly in iOS (#4968) 2017-10-20 08:31:18 +03:00
69199a5df2 Fix hint color in ios, the attributedPlaceholder and placeholder was set following two very distinct paths (#4945) 2017-10-18 16:10:23 +03:00
374f31cbf7 fix(minor): reword missing-xml-error to be clearer (#4947) 2017-10-18 10:43:17 +03:00
cb6a75c107 Fix crash on API 23 where constantState.newDrawable(nativeView.getResources()); throws exception in Java. (#4959)
Fix https://github.com/bradmartin/nativescript-floatingactionbutton/issues/57
Addition to https://github.com/NativeScript/NativeScript/issues/4728
2017-10-18 10:35:07 +03:00
f0a060a477 tests: update test date-picker tests page in relation with issue 4851 (#4955) 2017-10-16 19:13:47 +03:00
f50ae4bb17 test: include test page for button highlight related to issue 4740 (#4952) 2017-10-16 14:01:39 +03:00
cb029225c3 Elements tab support for iOS Chrome DevTools (#4930)
* add initial implementation of the dom agent for ios

* add implementation of the css agent for ios

* refactor devtools inspector methods to somewhat accomodate ios and android

patch elements dom-node tests to test for ios too

* fix android dom-node test

* fix ios dom-node-tests to mock the ios devtools inspector properly

* fix: minor changes
2017-10-12 11:32:31 +03:00
15f0a025c1 Update ISSUE_TEMPLATE.md (#4937) 2017-10-11 13:13:11 +03:00
bafd331191 Updated platform declarations to ios 11 (#4922) 2017-10-06 11:33:20 +03:00
cc96b67e4e chore(docs): Update method descriptions (#4913)
* chore(docs): Update method descriptions

* Fix grammar
2017-10-04 18:48:03 +03:00
3891f3d3d2 Minor fixes (#4806) 2017-10-04 10:34:27 +02:00
35be4bc40a Animations improperly reset (#4900)
* Animations improperly reset

* Scope stop and start of animations to avoid blinks
2017-10-03 15:50:09 +03:00
1049fcc251 Revert _applyXMLAttributes to set style, rows, columns and fontAttributes as properties (#4911) 2017-10-03 15:40:27 +03:00
27773e96a6 Initial transitions are ingored on android (as they are on ios) because on API 21+ Transition class requires at least one layout pass before transitions are executed. If we don't ignore it our transition handlers won't execute and frame navigation won't execute because it thinks there is a pending navigation. (#4896)
Fix https://github.com/NativeScript/NativeScript/issues/4895
2017-09-28 09:19:06 +03:00
9b52bbcd29 If you set tap gesture on a button parent (e.g. some layout for example) and set tap handler on the button and click the button there is a chance to execute navigation with clear history. This will remove current fragment and will clear the button listener owner. Still android will fire the click handler and we will throw an exception. (#4898)
Fix https://github.com/NativeScript/NativeScript/issues/4897
2017-09-28 09:17:54 +03:00
d64bb1976e Revert using inline source map, we should do this only in development (#4890) 2017-09-26 13:48:00 +03:00
1e47117179 fix: DatePicker month off by 1 in Android (#4872) 2017-09-26 09:44:33 +03:00
6d7c1ff295 Avoid applying CSS multiple times (#4784)
* Move the applyStyleFromScope to onLoaded, when the views are created and id or className properties are set the CSS selectors are queried and applied multiple times

* Condense the changes when applying properties
2017-09-25 18:32:00 +03:00
b0577728be Return true if user has consumed the action (#4859)
Based on this: https://developer.android.com/reference/android/widget/TextView.OnEditorActionListener.html
And assuming that the developer will run dismissSoftInput in the owner.dismissSoftInput() only if they need to.
Returning False will close the keyboard regardless.
2017-09-25 15:46:01 +03:00
d8caf5583c chore(doc): Fixed coding convention link 2017-09-25 15:05:01 +03:00
2f0d3b0e0b Add RssFeed to the ContentTypes considered as text (#4820) 2017-09-09 15:45:07 +03:00
9ad297f2d7 Update changelog for 3.2.0 (#4809) 2017-09-07 14:35:13 +03:00
ea9213b243 edit broken page snippet tag (#4776)
* edit broken page snippet tag

* Increase timeout for HTTP tests (#4775)

* Typos (#4789)

* TypeScript 2.5 compatibility (#4794)

* edit broken page snippet tag

* fix(date-picker): Date picker changed check (#4797)

* edit broken page snippet tag
2017-09-05 18:23:46 +03:00