javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 11:01:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve the pull request template wording

Browse Source
This commit is contained in:
Erjan Gavalji
2016-07-27 10:37:49 +03:00
parent 20c7284fb4
commit fd82ae460b
1 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,18 +1,12 @@
Dear friend, we, the rest of the NativeScript community thank you for your To help the rest of the community review your change, please ensure:
contribution! Because we want to present a really nice, readable changelog with each
release, please provide the following information:
### Create a meaningful title ### PR has a meaningful title
Please, ensure your title is less than 50 characters and starts with a capital A good title is less than 50 characters and starts with a capital
letter. We strive to follow the guidelines in the letter, similar to a good [Git Commit Message] (http://chris.beams.io/posts/git-commit/).
[How to Write a Git Commit Message] (http://chris.beams.io/posts/git-commit/)
article for PR titles.
### Does your commit message include the wording below to reference a specific issue in this repo? ### The commit message references a specific issue in this repo
Fixes/Implements #[Issue Number]. Fixes/Implements #[Issue Number].
### Does your pull request have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md)? ### You have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md)
If not, why? if appropriate.
If not, please tell us why tests are not included, and list all steps needed to test your pull request manually.