From fd82ae460b6cc900a18569c42dfcb430d9b98c53 Mon Sep 17 00:00:00 2001 From: Erjan Gavalji Date: Wed, 27 Jul 2016 10:37:49 +0300 Subject: [PATCH] Improve the pull request template wording --- .github/PULL_REQUEST_TEMPLATE.md | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 485cbce02..bcbd472ae 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,18 +1,12 @@ -Dear friend, we, the rest of the NativeScript community thank you for your -contribution! Because we want to present a really nice, readable changelog with each -release, please provide the following information: +To help the rest of the community review your change, please ensure: -### Create a meaningful title -Please, ensure your title is less than 50 characters and starts with a capital -letter. We strive to follow the guidelines in the -[How to Write a Git Commit Message] (http://chris.beams.io/posts/git-commit/) -article for PR titles. +### PR has a meaningful title +A good title is less than 50 characters and starts with a capital +letter, similar to a good [Git Commit Message] (http://chris.beams.io/posts/git-commit/). -### Does your commit message include the wording below to reference a specific issue in this repo? +### The commit message references a specific issue in this repo Fixes/Implements #[Issue Number]. -### Does your pull request have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md)? -If not, why? -If not, please tell us why tests are not included, and list all steps needed to test your pull request manually. - +### You have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md) +if appropriate.