javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improved core barrel exports and Application class (#10286)

Browse Source 
BREAKING CHANGES:

`Application.orientation` is no longer a function.

Migration: Remove `()` from the `Application.orientation()` call:
```diff
import { Application } from "@nativescript/core";

-console.log(Application.orientation());
+console.log(Application.orientation);
```


`Application.systemAppearance` is no longer a function.

Migration: Remove `()` from the `Application.systemAppearance()` call:
```diff
import { Application } from "@nativescript/core";

-console.log(Application.systemAppearance());
+console.log(Application.systemAppearance);
```
This commit is contained in:
Igor Randjelovic
2023-05-17 21:02:06 +02:00
committed by Nathan Walker
parent 963d0243de
commit f64355ba7a
67 changed files with 3536 additions and 3678 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/automated/src/application/application-tests-common.ts
View File

@@ -1,5 +1,4 @@
import * as app from '@nativescript/core/application';
import { isAndroid, isIOS, Device, Application, platformNames } from '@nativescript/core';
import { isAndroid, isIOS, Device, Application, platformNames } from '@nativescript/core';
import * as TKUnit from '../tk-unit';
@@ -11,9 +10,9 @@ if (isAndroid) {
export function testInitialized() {
if (Device.os === platformNames.android) {
TKUnit.assert(app.android, 'Application module not properly intialized');
TKUnit.assert(Application.android, 'Application module not properly intialized');
} else if (Device.os === platformNames.ios) {
TKUnit.assert(app.ios, 'Application module not properly intialized');
TKUnit.assert(Application.ios, 'Application module not properly intialized');
}
}
@@ -23,5 +22,5 @@ export function testDisplayedEvent() {
}
export function testOrientation() {
TKUnit.assert(Application.orientation(), 'Orientation not initialized.');
TKUnit.assert(Application.orientation, 'Orientation not initialized.');
}

6
apps/automated/src/application/application-tests.android.ts
View File

@@ -40,7 +40,11 @@ export function testAndroidApplicationInitialized() {
TKUnit.assert(Application.android, 'Android application not initialized.');
TKUnit.assert(Application.android.context, 'Android context not initialized.');
TKUnit.assert(Application.android.foregroundActivity, 'Android foregroundActivity not initialized.');
TKUnit.assert(Application.android.foregroundActivity.isNativeScriptActivity, 'Android foregroundActivity.isNativeScriptActivity is false.');
TKUnit.assert(
// @ts-expect-error
Application.android.foregroundActivity.isNativeScriptActivity,
'Android foregroundActivity.isNativeScriptActivity is false.'
);
TKUnit.assert(Application.android.startActivity, 'Android startActivity not initialized.');
TKUnit.assert(Application.android.nativeApp, 'Android nativeApp not initialized.');
TKUnit.assert(Application.android.orientation, 'Android orientation not initialized.');