javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 03:31:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1236 from NativeScript/issue-1235

Browse Source 
Fixed Issue ##1235: ObservableArray does not raise its `change` event…
This commit is contained in:
Rossen Hristov
2015-12-11 14:12:41 +02:00
parent 1327f3a094 1717b33622
commit eda2f3f4dd
2 changed files with 41 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
apps/tests/observable-array-tests.ts
View File

@ -606,6 +606,46 @@ export var test_ObservableArray_lastIndexOfShouldReturnCorrectIndexStartingFrom
TKUnit.assert(result === 1, "ObservableArray lastIndexOf() should return correct index!");
};
export var test_ObservableArray_settingLengthToZeroPerformsSplice = function () {
var array = new observableArrayModule.ObservableArray([1, 2, 3]);
var changeRaised = false;
array.on("change", (args: observableArrayModule.ChangedData<number>) => {
changeRaised = true;
TKUnit.assertEqual(args.object, array);
TKUnit.assertEqual(args.eventName, "change");
TKUnit.assertEqual(args.action, observableArrayModule.ChangeType.Splice);
TKUnit.assertEqual(args.index, 0);
TKUnit.assertEqual(args.addedCount, 0);
TKUnit.arrayAssert(args.removed, [1, 2, 3]);
});
array.length = 0;
TKUnit.assertEqual(array.length, 0);
TKUnit.assertTrue(changeRaised);
};
export var test_ObservableArray_settingLengthToSomethingPerformsSplice = function () {
var array = new observableArrayModule.ObservableArray([1, 2, 3]);
var changeRaised = false;
array.on("change", (args: observableArrayModule.ChangedData<number>) => {
changeRaised = true;
TKUnit.assertEqual(args.object, array);
TKUnit.assertEqual(args.eventName, "change");
TKUnit.assertEqual(args.action, observableArrayModule.ChangeType.Splice);
TKUnit.assertEqual(args.index, 1);
TKUnit.assertEqual(args.addedCount, 0);
TKUnit.arrayAssert(args.removed, [2, 3]);
});
array.length = 1;
TKUnit.assertEqual(array.length, 1);
TKUnit.assertTrue(changeRaised);
};
var array = new observableArrayModule.ObservableArray();
// We do not have indexer!

3
data/observable-array/observable-array.ts
View File

@ -70,8 +70,7 @@ export class ObservableArray<T> extends observable.Observable implements observa
}
set length(value: number) {
if (types.isNumber(value) && this._array && this._array.length !== value) {
this._array = this._array.slice(0, value);
this._notifyLengthChange();
this.splice(value, this._array.length - value);
}
}