javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-18 13:51:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

in fact this does not seem to be necessary anymore

Browse Source
This commit is contained in:
Martin Guillon
2020-08-24 11:25:02 +02:00
parent 9a5d99e241
commit d41195e3f9
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/core/ui/frame/frame-common.ts
View File

@ -259,7 +259,7 @@ export class FrameBase extends CustomLayoutView {
public _updateBackstack(entry: BackstackEntry, navigationType: NavigationType): void {
const isBack = navigationType === NavigationType.back;
const isReplace = navigationType === NavigationType.replace;
this.raiseCurrentPageNavigatedEvents(isBack, isReplace, entry.entry.clearHistory);
this.raiseCurrentPageNavigatedEvents(isBack);
const current = this._currentEntry;
// Do nothing for Hot Module Replacement
@ -293,14 +293,9 @@ export class FrameBase extends CustomLayoutView {
return false;
}
private raiseCurrentPageNavigatedEvents(isBack: boolean, isReplace: boolean, clearHistory: boolean) {
private raiseCurrentPageNavigatedEvents(isBack: boolean) {
const page = this.currentPage;
if (page) {
if ((isBack || isReplace || clearHistory) && page.isLoaded) {
console.log('unloading current page');
// Forward navigation does not remove page from frame so we raise unloaded manually.
page.callUnloaded();
}
page.onNavigatedFrom(isBack);
}
}